Subject: Re: [PATCH] zd1211rw-mac80211: Fix for monitor mode bug
From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andy Green <andy@warmcat.com>, Jiri Benc <jbenc@suse.cz>,
	Daniel Drake <dsd@gentoo.org>, linville@tuxdriver.com,
	linux-wireless@vger.kernel.org, kune@deine-taler.de
In-Reply-To: <200703261328.28156.mb@bu3sch.de>
References: <20070325231817.9C5887B409F@zog.reactivated.net>
	 <1174903199.1536.4.camel@johannes.berg> <46079CEC.5030207@warmcat.com>
	 <200703261328.28156.mb@bu3sch.de>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-x8SPJWVYSKHbGWFgMRCm"
Date: Mon, 26 Mar 2007 13:31:06 +0200
Message-Id: <1174908666.1536.15.camel@johannes.berg>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org


--=-x8SPJWVYSKHbGWFgMRCm
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 2007-03-26 at 13:28 +0200, Michael Buesch wrote:

> We currently have two module parameters in bcm43xx-mac80211 for this:
>=20
> static int modparam_mon_keep_bad;
> module_param_named(mon_keep_bad, modparam_mon_keep_bad, int, 0444);
> MODULE_PARM_DESC(mon_keep_bad, "Keep bad frames in monitor mode");
>=20
> static int modparam_mon_keep_badplcp;
> module_param_named(mon_keep_badplcp, modparam_mon_keep_bad, int, 0444);
> MODULE_PARM_DESC(mon_keep_badplcp, "Keep frames with bad PLCP in monitor =
mode");

Out of curiosity, doesn't that break things when you have both a monitor
and a non-monitor interface [1]? Or do you just disable it then?

johannes

[1] I think that mac80211 assumes CRC checks have passed, no?

--=-x8SPJWVYSKHbGWFgMRCm
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Comment: Johannes Berg (powerbook)

iD8DBQBGB676/ETPhpq3jKURApOCAKCfAbLU2Y1fOf+aTzdRpuhSewhgDwCfVuZa
GycRX8ilMAvegdPfrq+hPNc=
=S7o7
-----END PGP SIGNATURE-----

--=-x8SPJWVYSKHbGWFgMRCm--