Return-path: Received: from smtp.osdl.org ([65.172.181.24]:50545 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933771AbXCZJWw (ORCPT ); Mon, 26 Mar 2007 05:22:52 -0400 Date: Mon, 26 Mar 2007 01:22:32 -0800 From: Andrew Morton To: Cornelia Huck Cc: Larry Finger , Matt Mackall , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, Monakhov Dmitriy , Eric Rannaud Subject: Re: 2.6.21-rc4-mm1 Message-Id: <20070326012232.0f0b9e09.akpm@linux-foundation.org> In-Reply-To: <20070326110949.5301a571@gondolin.boeblingen.de.ibm.com> References: <20070319205623.299d0378.akpm@linux-foundation.org> <1174433034.62033.16.camel@localhost> <20070320223643.d8cbc3f6.akpm@linux-foundation.org> <4601761F.4000302@lwfinger.net> <20070321185900.GC3801@tuxdriver.com> <20070321202225.GN10459@waste.org> <20070321233917.0393dfd1.akpm@linux-foundation.org> <20070322123508.3785fd30@gondolin.boeblingen.de.ibm.com> <4602752A.5050109@lwfinger.net> <20070322181019.62fe78ed@gondolin.boeblingen.de.ibm.com> <4602D137.4060402@lwfinger.net> <20070323111029.4089ccfb@gondolin.boeblingen.de.ibm.com> <20070323210618.6a41f5da.akpm@linux-foundation.org> <20070326110949.5301a571@gondolin.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 26 Mar 2007 11:09:49 +0200 Cornelia Huck wrote: > On Fri, 23 Mar 2007 21:06:18 -0800, > Andrew Morton wrote: > > > Would I be right in guessing that this was all triggered by > > uevent-improve-error-checking-and-handling.patch? > > Looks like it, since it passed the uevent failures to the upper layer. OK, thanks. > > If so, do you think I should labour on with > > uevent-improve-error-checking-and-handling.patch plus your fix, or should I > > drop the lot? (I'm inclined toward the latter, but I'm still not > > sure which patch(es) need to be dropped). > > This depends on what semantics uevent returning an error code should > have. The firmware code was using it to suppress uevents, but > uevent_suppress is a better idea now. So if we want uevent returning != > 0 to imply "something really bad happened", all uevent functions have > to be audited and those that work like firmware_uevent have to be > converted to uevent_suppress. This would be cleaner, but I'm not sure > it's worth the work. We're generally struggling to stay alive amongst all the bugs at present - I'll drop all those patches.