Date: Tue, 08 May 2007 13:27:37 -0700 (PDT)
Message-Id: <20070508.132737.104034594.davem@davemloft.net>
To: penberg@cs.helsinki.fi
Cc: jeff@garzik.org, linville@tuxdriver.com, dcbw@redhat.com,
	hch@infradead.org, linux-wireless@vger.kernel.org,
	marcelo@kvack.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: Please pull 'revert-libertas' branch of wireless-2.6
From: David Miller <davem@davemloft.net>
In-Reply-To: <84144f020705080247v74ebcd26y27c2f1e61529b215@mail.gmail.com>
References: <20070507141143.GB5125@tuxdriver.com>
	<463F443A.5000306@garzik.org>
	<84144f020705080247v74ebcd26y27c2f1e61529b215@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org

From: "Pekka Enberg" <penberg@cs.helsinki.fi>
Date: Tue, 8 May 2007 12:47:34 +0300

> On 5/7/07, Jeff Garzik <jeff@garzik.org> wrote:
> > Open source is about release early, release often.  Not "hide code in a
> > dark corner until Christoph thinks it is perfect."  We have high
> > standards for upstream merged code, but that standard is not perfection.
> 
> Please. This has nothing to do with Christoph. (1) the driver seems to
> break every Linux coding style convention known to man and (2) adds a
> new ABI with bunch of ioctls() that apparently haven't been reviewed
> properly. That's just not acceptable for mainline kernel!

I completely agree, these things should be corrected and if the the
author is being totally unresponsive to Christoph's review that's even
worse.

Every piece of code that I've written that Christoph has reviewed has
become significantly better because of his review.