Message-ID: <4640E4CE.1030506@garzik.org>
Date: Tue, 08 May 2007 16:59:58 -0400
From: Jeff Garzik <jeff@garzik.org>
MIME-Version: 1.0
To: Nick Piggin <nickpiggin@yahoo.com.au>
CC: Matt Mackall <mpm@selenic.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Dan Williams <dcbw@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-wireless@vger.kernel.org, marcelo@kvack.org,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re:  Please pull 'libertas' branch of wireless-2.6)
References: <20070227205649.GH5826@tuxdriver.com> <45E8CF5E.5090305@garzik.org> <20070303052140.GA31075@infradead.org> <20070507104117.GA31601@infradead.org> <1178539423.3032.24.camel@localhost.localdomain> <20070507141143.GB5125@tuxdriver.com> <463F443A.5000306@garzik.org> <20070508061255.GT11166@waste.org> <464034C2.3030007@yahoo.com.au>
In-Reply-To: <464034C2.3030007@yahoo.com.au>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Sender: linux-wireless-owner@vger.kernel.org

Nick Piggin wrote:
> Two things on top of a lot of people's pet peeves list are lack of
> good review bandwidth, and poor driver code! So it is sad this was
> merged without Christoph's comments being addressed. "it works for
> me, we can fix it later" is probably a big reason for quality
> problems of some parts of the kernel.
> 
> As for Christoph's idea of perfection... it usually isn't a bad
> thing. And he is quite reasonable if you explain your good reason
> to disagree or do something differently. The attitude of ignoring
> comments can be really demotivating for a reviewer.

I guess it's a good thing that the maintainer was not ignoring the 
review comments, then...

(please review the thread before replying, next time)

	Jeff