Return-path: Received: from smtp107.mail.mud.yahoo.com ([209.191.85.217]:35181 "HELO smtp107.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S934714AbXEHIfh (ORCPT ); Tue, 8 May 2007 04:35:37 -0400 Message-ID: <464034C2.3030007@yahoo.com.au> Date: Tue, 08 May 2007 18:28:50 +1000 From: Nick Piggin MIME-Version: 1.0 To: Matt Mackall CC: Jeff Garzik , "John W. Linville" , Dan Williams , Christoph Hellwig , linux-wireless@vger.kernel.org, marcelo@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Linus Torvalds Subject: Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6) References: <20070227205649.GH5826@tuxdriver.com> <45E8CF5E.5090305@garzik.org> <20070303052140.GA31075@infradead.org> <20070507104117.GA31601@infradead.org> <1178539423.3032.24.camel@localhost.localdomain> <20070507141143.GB5125@tuxdriver.com> <463F443A.5000306@garzik.org> <20070508061255.GT11166@waste.org> In-Reply-To: <20070508061255.GT11166@waste.org> Content-Type: text/plain; charset=us-ascii; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Matt Mackall wrote: > On Mon, May 07, 2007 at 11:22:34AM -0400, Jeff Garzik wrote: >>For my part, I _did_ review it. Twice. Once in the early days, and >>once when I pulled it into my netdev-2.6.git tree. libertas needs the >>changes mentioned in this thread. But the driver is in workable shape >>to be USED while being improved. I strongly dislike people being cowed >>into not merging a driver for years, because the driver in question does >>not meet Christoph's idea of perfection. > > > It's a shame to expose new ABI bits that we expect to change to > mainline. Getting rid of obsolete interfaces is next to impossible so > the introduction of new interfaces really does warrant serious > consideration. > > Can we come up with a scheme to keep the new ioctls introduced by this > driver from leaking over into distro-land before they get reworked? > Like preemptively adding a deprecation printk? And it isn't only ioctls, but just having code there to set a bad example, and added overhead of maintaining APIs used by the driver. Two things on top of a lot of people's pet peeves list are lack of good review bandwidth, and poor driver code! So it is sad this was merged without Christoph's comments being addressed. "it works for me, we can fix it later" is probably a big reason for quality problems of some parts of the kernel. As for Christoph's idea of perfection... it usually isn't a bad thing. And he is quite reasonable if you explain your good reason to disagree or do something differently. The attitude of ignoring comments can be really demotivating for a reviewer. -- SUSE Labs, Novell Inc.