From: Michael Buesch <mb@bu3sch.de>
To: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH RFC] mac80211: Make stop_queues() usable
Date: Tue, 3 Jul 2007 14:39:40 +0200
Cc: Michael Wu <flamingice@sourmilk.net>, Jiri Benc <jbenc@suse.cz>,
	John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org
References: <200707022235.38791.mb@bu3sch.de> <200707031039.56710.mb@bu3sch.de> <468A41A3.1020903@trash.net>
In-Reply-To: <468A41A3.1020903@trash.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Message-Id: <200707031439.40828.mb@bu3sch.de>
Sender: linux-wireless-owner@vger.kernel.org

On Tuesday 03 July 2007 14:31:31 Patrick McHardy wrote:
> Michael Buesch wrote:
> > On Tuesday 03 July 2007 06:09:19 Michael Wu wrote:
> > 
> >>On Monday 02 July 2007 13:35, Michael Buesch wrote:
> >>
> >>>+	netif_tx_lock_bh(mdev);
> >>> 	for (i = 0; i < hw->queues; i++)
> >>> 		ieee80211_stop_queue(hw, i);
> >>>+	netif_tx_unlock_bh(mdev);
> >>
> >>Well, looks like this will break stopping all tx queues from the tx handler by 
> >>deadlocking. It may be useless for bcm43xx to call ieee80211_stop_queue, but 
> >>there are other drivers which rely on it.
> 
> 
> The wireless multiqueue handling should be replaced by the generic
> implementation in net-2.6.23 (using prio, seperating out the wme
> classifier and killing the broken scheduler). You don't need to
> stop individual subqueues for a full shutdown with that implementation,
> you can just stop the global queue. Not sure if that really helps for
> this case though since I didn't look to deep into this code.

That's exactly what I want. Stop the "global queue".
As there is no "global queue" in mac80211, I need to stop every queue.

-- 
Greetings Michael.