Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:50577 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbXH1RKj (ORCPT ); Tue, 28 Aug 2007 13:10:39 -0400 Date: Tue, 28 Aug 2007 18:10:34 +0100 From: Christoph Hellwig To: Jiri Slaby Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals Message-ID: <20070828171034.GB29343@infradead.org> References: <2713029743177393055@pripojeni.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <2713029743177393055@pripojeni.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > + ath5k_hw_phy.o ath5k_hw_inivals.o And while I'm at nitpicking :) ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by most drivers and ath5k_hw_inivals.o mights aswell be something like ath5k_init.o