Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:52358 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760488AbXH3QsO (ORCPT ); Thu, 30 Aug 2007 12:48:14 -0400 Date: Thu, 30 Aug 2007 10:48:13 -0600 From: Matthew Wilcox To: Stephen Hemminger Cc: "David S. Miller" , Johannes Berg , Jochen Voss , linux wireless list , linville@tuxdriver.com, netdev , bridge@linux-foundation.org Subject: Re: [PATCH] bridge: fix OOPS when bridging device without ethtool Message-ID: <20070830164812.GW14130@parisc-linux.org> References: <20070829223752.GA6969@seehuhn.de> <1188475530.2963.20.camel@johannes.berg> <20070830074949.7cd25b04@freepuppy.rosehill.hemminger.net> <20070830145840.GU14130@parisc-linux.org> <20070830082932.71272c3d@freepuppy.rosehill.hemminger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20070830082932.71272c3d@freepuppy.rosehill.hemminger.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote: > Bridge code calls ethtool to get speed. The conversion to using > only ethtool_ops broke the case of devices without ethtool_ops. > This is a new regression in 2.6.23. > > Rearranged the switch to a logical order, and use gcc initializer. > > Ps: speed should have been part of the network device structure from > the start rather than burying it in ethtool. Feel free to do the conversion ;-) One of the things I like about the ethtool framework is it gives us a way to take stuff out of the drivers and put it in the midlayer without disturbing userspace. > Signed-off-by: Stephen Hemminger Acked-by: Matthew Wilcox -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."