Return-path: Received: from smtp146.iad.emailsrvr.com ([207.97.245.146]:50000 "EHLO smtp146.iad.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759080AbXH3R4a (ORCPT ); Thu, 30 Aug 2007 13:56:30 -0400 Message-ID: <46D70467.1040109@gentoo.org> Date: Thu, 30 Aug 2007 13:54:47 -0400 From: Daniel Drake MIME-Version: 1.0 To: Jesper Juhl CC: Linux Kernel Mailing List , netdev@vger.kernel.org, "David S. Miller" , Ulrich Kunitz , linux-wireless@vger.kernel.org Subject: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver References: <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Jesper Juhl wrote: > Since kmalloc() returns a void pointer there is no reason to cast > its return value. > This patch also removes a pointless initialization of a variable. NAK: adds a sparse warning zd_chip.c:116:15: warning: implicit cast to nocast type > Signed-off-by: Jesper Juhl > --- > drivers/net/wireless/zd1211rw/zd_chip.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c > index c39f198..4942e5c 100644 > --- a/drivers/net/wireless/zd1211rw/zd_chip.c > +++ b/drivers/net/wireless/zd1211rw/zd_chip.c > @@ -106,8 +106,8 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr > { > int r; > int i; > - zd_addr_t *a16 = (zd_addr_t *)NULL; > u16 *v16; > + zd_addr_t *a16; > unsigned int count16; > > if (count > USB_MAX_IOREAD32_COUNT) > @@ -115,8 +115,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr > > /* Allocate a single memory block for values and addresses. */ > count16 = 2*count; > - a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), > - GFP_KERNEL); > + a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), GFP_KERNEL); > if (!a16) { > dev_dbg_f(zd_chip_dev(chip), > "error ENOMEM in allocation of a16\n");