Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:3998 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753206AbXIFIUw (ORCPT ); Thu, 6 Sep 2007 04:20:52 -0400 Date: Thu, 6 Sep 2007 16:20:08 +0800 From: Herbert Xu To: Satyam Sharma Cc: Florian Lohoff , Linux Kernel Mailing List , Netdev , linux-wireless@vger.kernel.org, Michal Piotrowski , ipw3945-devel@lists.sourceforge.net, yi.zhu@intel.com Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170 Message-ID: <20070906082008.GA21929@gondor.apana.org.au> References: <20070902184439.GA14306@paradigm.rfc822.org> <6bffcb0e0709021659o3856cd06gabc054c949a84397@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote: > > Probably tangential, but Herbert, is the call to synchronize_rcu() in > dev_deactivate() really correct? Yes it's still correct as of today's tree. Of course patches such as preemptible RCU may change things but they'll need to audit this anyway. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt