Return-path: Received: from nz-out-0506.google.com ([64.233.162.239]:36651 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760780AbXISPH0 (ORCPT ); Wed, 19 Sep 2007 11:07:26 -0400 Received: by nz-out-0506.google.com with SMTP id s18so181992nze for ; Wed, 19 Sep 2007 08:07:17 -0700 (PDT) Message-ID: <40f31dec0709190807k5ea36ce8h615764a49c49efc@mail.gmail.com> Date: Wed, 19 Sep 2007 18:07:17 +0300 From: "Nick Kossifidis" To: "Alan Cox" Subject: Re: [PATCH] Clarify pci_iomap() usage for MMIO-only devices Cc: "Linus Torvalds" , "Luis R. Rodriguez" , linux-kernel , "Jeff Garzik" , "John W. Linville" , linux-wireless In-Reply-To: <20070918232546.004af9ff@the-village.bc.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <43e72e890709171322x76ab6b70xd29bf97e3643c553@mail.gmail.com> <20070918113401.6a8a737f@the-village.bc.nu> <43e72e890709181146s604e0f9fl8b0c16627469c77f@mail.gmail.com> <20070918232546.004af9ff@the-village.bc.nu> Sender: linux-wireless-owner@vger.kernel.org List-ID: 2007/9/19, Alan Cox : > > If you use ioport_map/unmap, then you really *should* access them with the > > proper iomem accessors (ioread/iowrite). The fact that it may happen to > > work (when using the default lib/iomap.c implementation, at least) on > > some architectures and with the current implementation still doesn't mean > > that you should necessarily use readb/writeb. > > Another reason we should enforce the use of ioread/iowrite is that some > platforms do daft things like map mmio type devices through indirect > register access. Sparc PCMCIA is a classic example. The only sane way to > make these work is to require ioread/iowrite is used with iomap > Hmm, we 've had bug reports about driver (madwifi-old-openhal) not working on Sparc64, can someone test if this is the case (the fact that we used readl/writel instead of ioread/iowrite on madwifi-old-openhal) ? It was really weird because we handle big-endian machines ok (madwifi-old-openhal on ppc worked fine). (ath5k was based on madwifi-old-openhal) -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick