Return-path: Received: from crystal.sipsolutions.net ([195.210.38.204]:35015 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751796AbXIFPSl (ORCPT ); Thu, 6 Sep 2007 11:18:41 -0400 Subject: Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170 From: Johannes Berg To: Herbert Xu Cc: Satyam Sharma , Florian Lohoff , Linux Kernel Mailing List , Netdev , linux-wireless@vger.kernel.org, Michal Piotrowski , ipw3945-devel@lists.sourceforge.net, yi.zhu@intel.com In-Reply-To: <20070906082301.GB21929@gondor.apana.org.au> References: <20070902184439.GA14306@paradigm.rfc822.org> <6bffcb0e0709021659o3856cd06gabc054c949a84397@mail.gmail.com> <20070906082301.GB21929@gondor.apana.org.au> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-P0JM25PSs9MHCk1RoLrB" Date: Thu, 06 Sep 2007 17:19:55 +0200 Message-Id: <1189091995.28781.99.camel@johannes.berg> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: --=-P0JM25PSs9MHCk1RoLrB Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote: > On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote: > >=20 > > > > [ 382.529041] [] dev_close+0x24/0x67 > > > > [ 382.529052] [] ieee80211_master_stop+0x4a/0x6d [mac80= 211] >=20 > This is where the bug is. You cannot call dev_close from an > atomic context as i33380211_master_stop does it within spin > locks. Oh btw. Can we stick a might_sleep() into dev_close() *before* the test whether the device is up? That way, we'd have seen the bug, but apparently nobody before Florian ever did a 'ip link set wmaster0 down' while the other interfaces were still open. johannes --=-P0JM25PSs9MHCk1RoLrB Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Comment: Johannes Berg (powerbook) iD8DBQBG4Bqb/ETPhpq3jKURAodYAJ9Ue7BZ2OM/mODT3BxY5BZTViKo5gCgrEkC LpH1f969DmQIZpNHoSH2Ank= =vRYa -----END PGP SIGNATURE----- --=-P0JM25PSs9MHCk1RoLrB--