Return-path: Received: from smtp.rutgers.edu ([128.6.72.243]:57614 "EHLO annwn14.rutgers.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758242AbXJDPQ5 (ORCPT ); Thu, 4 Oct 2007 11:16:57 -0400 From: Michael Wu To: Michael Buesch Subject: Re: [PATCH] mac80211: Fix TX after monitor interface is converted to managed Date: Thu, 4 Oct 2007 11:14:58 -0400 Cc: Daniel Drake , linville@tuxdriver.com, johannes@sipsolutions.net, netdev@vger.kernel.org, linux-wireless@vger.kernel.org References: <20071004113343.552139D502B@zog.reactivated.net> <200710041034.48533.flamingice@sourmilk.net> <200710041706.06182.mb@bu3sch.de> In-Reply-To: <200710041706.06182.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3294882.C8Ou6vCo8u"; protocol="application/pgp-signature"; micalg=pgp-sha1 Message-Id: <200710041115.02945.flamingice@sourmilk.net> (sfid-20071004_161715_433775_48FB4507) Sender: linux-wireless-owner@vger.kernel.org List-ID: --nextPart3294882.C8Ou6vCo8u Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 04 October 2007 11:06, Michael Buesch wrote: > The reason why BUG_ON exists is to catch bugs that happen, although > they Should Never Happen (tm) ;) This is just paranoia. There's plenty of other BUG_ONs which we use to catc= h=20 bugs caused by drivers doing silly things. We can verify that this conditio= n=20 will never occur within the mac80211 layer, so there's no need to have it.= =20 The only thing this can catch is someone deciding to manually invoke=20 dev->uninit, which only the unregister code should be doing. =2DMichael Wu --nextPart3294882.C8Ou6vCo8u Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBHBQN2T3Oqt9AH4aERAhkUAKDNagw/FPR6F73K7KnOGIY00SJInACg0Z6H JapIyxbMHpwP8yy6XWyH614= =c/eP -----END PGP SIGNATURE----- --nextPart3294882.C8Ou6vCo8u--