Return-path: Received: from py-out-1112.google.com ([64.233.166.179]:44270 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbXJVPBE (ORCPT ); Mon, 22 Oct 2007 11:01:04 -0400 Received: by py-out-1112.google.com with SMTP id u77so2492963pyb for ; Mon, 22 Oct 2007 08:00:58 -0700 (PDT) Message-ID: <43e72e890710220800j3d610b4by58b28598388eb8b8@mail.gmail.com> (sfid-20071022_160110_323746_ED17D411) Date: Mon, 22 Oct 2007 11:00:58 -0400 From: "Luis R. Rodriguez" To: "Jiri Slaby" Subject: Re: [PATCH 0/2] ath5k: Further cleanups inside base.c Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com In-Reply-To: <471AF51E.7050901@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <20071021012030.GA5817@localhost.domain.invalid> <471AF51E.7050901@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/21/07, Jiri Slaby wrote: > On 10/21/2007 03:20 AM, Nick Kossifidis wrote: > > A few more cleanups for base.c before i submit the rest of my fixes... > > > > Q: Should we get rid of syctl stuff ? I mean user can only change > > calibration interval (which is something tricky for users to play with) > > and debug flags. Does anyone use this ? i mean we can put printks wherever > > we want, there's no need for this stuff IMHO (it comes from madwifi). > > Agreed. And if really want it, we can make debug a module_param... It should be removed, but please use 30 seconds for the calibration timer instead of every second. Every second is pretty obsessive considering the fact that even though run every second, we don't calibrate even if AR5K_PHY_IQ_RUN was set. Most of the times i_coffd or q_coffd will be 0, so all we actually do is noise floor calibration. Luis