Return-path: Received: from fk-out-0910.google.com ([209.85.128.191]:15527 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751002AbXLRJYH (ORCPT ); Tue, 18 Dec 2007 04:24:07 -0500 Received: by fk-out-0910.google.com with SMTP id z23so1952184fkz.5 for ; Tue, 18 Dec 2007 01:24:04 -0800 (PST) Message-ID: (sfid-20071218_092419_124293_911C6B4B) Date: Tue, 18 Dec 2007 11:24:04 +0200 From: "Ron Rindjunsky" To: "Johannes Berg" Subject: Re: [PATCH 1/1] mac80211: pass in PS_POLL frames Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, flamingice@sourmilk.net, tomas.winkler@intel.com, yi.zhu@intel.com In-Reply-To: <1197913576.4885.57.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1197278205280-git-send-email-ron.rindjunsky@intel.com> <1197913576.4885.57.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: > > + if (sdata->type == IEEE80211_IF_TYPE_STA) > > + return TXRX_DROP; > > Should we maybe do the test explicitly for when we want it, i.e. > AP/VLAN/IBSS cases? Just thinking of the mesh networking stuff etc. > that's being added... no problem, i'll send it over. currently i see only AP mode as relevant. > > Other than that, looks fine. > > johannes > >