Message-ID: <20071223165215.7u8ydchc00kk0cow@imap.suse.de> (sfid-20071223_155229_541339_B333EDF0)
Date: Sun, 23 Dec 2007 16:52:15 +0100
From: Helmut Schaa <hschaa@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Zhu Yi <yi.zhu@intel.com>
Subject: Re: [PATCH] mac80211: Restore rx.fc before every invocation of
	ieee80211_invoke_rx_handlers
References: <200712211516.35731.hschaa@suse.de>
	(sfid-20071221_141215_108356_0F4BE6F7)
	<1198401880.4116.6.camel@johannes.berg>
	<20071223123517.17ds9zttxc4goo00@imap.suse.de>
	<1198417706.4000.1.camel@johannes.berg>
In-Reply-To: <1198417706.4000.1.camel@johannes.berg>
MIME-Version: 1.0
Content-Type: text/plain;
	charset=UTF-8;
	DelSp="Yes";
	format="flowed"
Sender: linux-wireless-owner@vger.kernel.org

Am So 23 Dez 2007 14:48:26 CET schrieb Johannes Berg  
<johannes@sipsolutions.net>:

>
>> >> This patch fixes a problem with rx handling on multiple interfaces.
>> >>  Especially
>> >> when using hardware-scanning and a wireless driver (i.e.   
>> iwlwifi) which is
>> >> able to receive data while scanning.
>> >
>> > Can you explain how you even got multiple interfaces with iwlwifi? The
>> > patch looks (superficially) correct, but I'm a bit confused.
>>
>> I was only referring to wmaster0 and wlan0 as two interfaces. While a scan
>> is in progress the master interface (wmaster0) processes all frames related
>> to scanning and it happened to me that data-frames got dropped on wmaster0
>> (which is obviously correct) and due to the frame control being modified
>> wlan0 was not able to process the frame correctly anymore.
>
> Ah, that must be because of the stuff Zhu Yi did wrt. hw scanning. Could

Exactly.

> you take a look too please? The patch looks pretty much ok to me and I
> think it'd be required with say VLAN interfaces as well.

The patch looks fine to me too and with the additional patch I was  
able to receive data while a scan is in progress (hw_scan only of  
course).

Helmut