Return-path: Received: from ra.tuxdriver.com ([70.61.120.52]:3174 "EHLO ra.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933450AbXLQU7k (ORCPT ); Mon, 17 Dec 2007 15:59:40 -0500 Date: Mon, 17 Dec 2007 15:41:12 -0500 From: "John W. Linville" To: Stefano Brivio Cc: Mattias Nissler , linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [patch 4/9] mac80211: Make PID rate control algorithm the default Message-ID: <20071217204112.GE3121@tuxdriver.com> (sfid-20071217_205949_754061_7DA45D08) References: <20071217012517.882216322@gmx.de> <20071217012550.213561122@gmx.de> <20071217150202.GC3121@tuxdriver.com> <20071217210649.370ba385@morte> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20071217210649.370ba385@morte> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Dec 17, 2007 at 09:06:49PM +0100, Stefano Brivio wrote: > On Mon, 17 Dec 2007 10:02:02 -0500 > "John W. Linville" wrote: > > > On Mon, Dec 17, 2007 at 02:25:21AM +0100, Mattias Nissler wrote: > > > > > config MAC80211_RCPID > > > - bool "'PID' rate control algorithm" if EMBEDDED > > > + bool "'PID' rate control algorithm" > > > > Shouldn't this keep the "if EMBEDDED"? Especially if it is going to be the default? > > How is EMBEDDED supposed to be related to this? Anyway, I'll go for the two > modules approach, forcing one module to be selected. As I recall, the "if EMBEDDED" was there basically to say "it should always be built-in, but if you are trying to totally minimize your footprint you can turn it off". Of course, that still would only work if you had another rate control algorithm available e.g. the iwlwifi drivers. John -- John W. Linville linville@tuxdriver.com