Return-path: Received: from rv-out-0910.google.com ([209.85.198.190]:53462 "EHLO rv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436AbYA3JLu (ORCPT ); Wed, 30 Jan 2008 04:11:50 -0500 Received: by rv-out-0910.google.com with SMTP id k20so144507rvb.1 for ; Wed, 30 Jan 2008 01:11:47 -0800 (PST) Message-ID: (sfid-20080130_091156_409652_13F72857) Date: Wed, 30 Jan 2008 11:11:47 +0200 From: "Ron Rindjunsky" To: "Johannes Berg" Subject: Re: [PATCH 06/12] mac80211: A-MPDU Tx adding qdisc support Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, flamingice@sourmilk.net, tomas.winkler@intel.com, yi.zhu@intel.com In-Reply-To: <1201623169.4394.35.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <12009163321727-git-send-email-ron.rindjunsky@intel.com> <12009163392546-git-send-email-ron.rindjunsky@intel.com> <1201167778.3454.75.camel@johannes.berg> <1201623169.4394.35.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: > > I can change this book keeping, though current solution provides us up > > to 32 HW queues, which is really a huge amout of queues in terms of > > HW. if needed after all, i would prefer to do it on top of this > > series. > > Well you don't really need to change any code I think, only use > > unsigned long qdisc_pool[BITS_TO_LONGS(NUM_TX_DATA_QUEUES_AMPDU)]; > > instead and that way we should already be safe for future increases of > the NUM_TX_DATA_QUEUES_AMPDU value. set_bit/clear_bit/etc. are already > prepared to handle such an array so I'd prefer to have it right away > just so there are less gotchas when that happens. right, i missed your point first time, i'll change it.