Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from ra.tuxdriver.com ([70.61.120.52]:2471 "EHLO ra.tuxdriver.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757543AbYAaVcH (ORCPT <rfc822;linux-wireless@vger.kernel.org>);
	Thu, 31 Jan 2008 16:32:07 -0500
Date: Thu, 31 Jan 2008 16:03:38 -0500
From: "John W. Linville" <linville@tuxdriver.com>
To: Chris Clayton <chris2553@googlemail.com>
Cc: linux-wireless@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: Silent crash witk 2-6.24-rc8-git4
Message-ID: <20080131210338.GK6413@tuxdriver.com> (sfid-20080131_213213_373449_717D9846)
References: <200801220603.02986.chris2553@googlemail.com> <200801231642.58782.chris2553@googlemail.com> <20080123190207.GB3129@tuxdriver.com> <200801312013.31220.chris2553@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <200801312013.31220.chris2553@googlemail.com>
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On Thu, Jan 31, 2008 at 08:13:31PM +0000, Chris Clayton wrote:
> Hi John,
> 
> On Wednesday 23 January 2008, John W. Linville wrote:
> > On Wed, Jan 23, 2008 at 04:42:58PM +0000, Chris Clayton wrote:
> > > On Wednesday 23 January 2008, Chris Clayton wrote:
> > > > Hi again.
> > > > 
> > > > On Tuesday 22 January 2008, Chris Clayton wrote:
> > > > > Hi,
> > > 
> > > and here's another, slightly more complete, one, this time from 2.6.24-rc8-git6
> > > (the none I sent earlier was from -git4, by the way)
> > > 
> > > Call Trace:
> > > [<c011440a>] __update_rq_clock+0x1a/0xf0
> > > [<e08ff59d>] rt2x00lib_txdone+0x9d/0xd0 [rt2x00lib]
> > > [<e0909573>] rt61pci_txdone+0x153/0x1f0 [rt61pci]
> > > [<e09096ad>] rt61pci_interrupt+0x9d/0xb0 [rt61pci]
> > 
> > I suspect this could relate to this commit:
> > 
> > commit 62bc060b8ed5fcdafd87da5ab17bdd59a39ebcc9
> > Author: Mattias Nissler <mattias.nissler@gmx.de>
> > Date:   Mon Nov 12 15:03:12 2007 +0100
> > 
> >     rt2x00: Allow rt61 to catch up after a missing tx report
> > 
> > Could you revert that patch, rebuild, and try to recreate the problem?
> 
> As you will have seen, Matthias doubted whether his patch would be at the root
> of the problem I am seeing. I noticed you posted some patches earlier this week.
> Would any combination of those be likely to fix the bug, please? The patch
> http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream/0001-rt61pci-fix-up-merge-damage.patch
> applies cleanly to 2.6.24 but the build fails :(

This patch is not intended for 2.6.24, so that won't help. :-)

I saw Mattias's reply, but I didn't see him suggest any other
fixes... :-(  I'm wondering if maybe you tried reverting it anyway?
I only ask because the call trace references symbols that would seem
to relate to the patch.  So even if _why_ it might break things isn't
obvious, it still might be worth trying a revert "just in case". :-)

> It seems that it may take a little while to get to the bottom of this bug. Should
> I raise an incident on bugzilla?

I've seen other reports of rt61 working fine with 2.6.24.  So I
suppose you should open a bug.

Thanks!

John
-- 
John W. Linville
linville@tuxdriver.com