Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:51062 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbYAJUbI (ORCPT ); Thu, 10 Jan 2008 15:31:08 -0500 Date: Thu, 10 Jan 2008 12:28:59 -0800 From: Randy Dunlap To: Roel Kluin <12o3l@tiscali.nl> Cc: linville@tuxdriver.com, lkml , linux-wireless@vger.kernel.org Subject: Re: [PATCH wireless/arlan] Replace logical- by bit-and Message-Id: <20080110122859.569b3774.randy.dunlap@oracle.com> (sfid-20080110_203113_882273_0EBE555D) In-Reply-To: <47866EE9.80003@tiscali.nl> References: <4722453E.2090801@tiscali.nl> <472248AC.7080201@tiscali.nl> <47866EE9.80003@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > Totally untested patch below from linus' git tree. The && is incorrect, right? > > from drivers/net/wireless/arlan.h:390: > #define ARLAN_POWER 0x40 > #define ARLAN_ACCESS 0x80 > > Replace logical and by bit-and > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> > --- > diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h > index 3ed1df7..7b7498f 100644 > --- a/drivers/net/wireless/arlan.h > +++ b/drivers/net/wireless/arlan.h > @@ -485,7 +485,7 @@ struct arlan_private { > #define clearClearInterrupt(dev){\ > writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_CLEAR_INTERRUPT);} > #define setPowerOff(dev){\ > - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && ARLAN_ACCESS));\ > + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & ARLAN_ACCESS));\ eh? How does that help? 0x80 && 0x40 -> 0 0x80 & 0x40 -> 0 so readControlRegister() | (0) ?? Maybe it should be (ARLAN_POWER | ARLAN_ACCESS), but some arlan developer or someone with specs should help here... > writeControlRegister(dev,readControlRegister(dev) & ~ARLAN_ACCESS);} > #define setPowerOn(dev){\ > writeControlRegister(dev,readControlRegister(dev) & ~(ARLAN_POWER)); } or am I sleeping()? --- ~Randy