Return-path: Received: from fg-out-1718.google.com ([72.14.220.156]:7765 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbYABGcz (ORCPT ); Wed, 2 Jan 2008 01:32:55 -0500 Received: by fg-out-1718.google.com with SMTP id e21so3086828fga.17 for ; Tue, 01 Jan 2008 22:32:52 -0800 (PST) From: Chris Clayton Reply-To: chris2553@googlemail.com To: "Ivo Van Doorn" Subject: Re: Warning emited by 2.6.24-rc6-git5 Date: Wed, 2 Jan 2008 06:32:31 +0000 Cc: "Kalle Valo" , "Johannes Berg" , linux-wireless@vger.kernel.org References: <200712290942.37396.chris2553@googlemail.com> <87abnrz5lk.fsf@nokia.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200801020632.31361.chris2553@googlemail.com> (sfid-20080102_063300_722206_7014F53B) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Monday 31 December 2007, Ivo Van Doorn wrote: > On Dec 31, 2007 8:27 AM, Kalle Valo wrote: > > Ivo van Doorn writes: > > > + /* > > > + * Move entire frame 2 bytes to the front. > > > + */ > > > + skb_push(skb, 2); > > > + memmove(skb->data, skb->data + 2, skb->len - 2); > > > > No skb_trim()? Shoudn't there be skb_trim(skb, 2) after memmove()? > > Good point, I completely forgot about that. :S > Thanks. :) > > Ivo Ah, does the patch I have applied and am running need enhancement, please? Thanks -- Beer is proof that God loves us and wants us to be happy - Benjamin Franklin