Return-path: Received: from nbd.name ([88.198.39.176]:39279 "EHLO ds10.mine.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbYBDPYg (ORCPT ); Mon, 4 Feb 2008 10:24:36 -0500 Message-ID: <47A72E13.8070305@openwrt.org> (sfid-20080204_152441_479078_2DFB741F) Date: Mon, 04 Feb 2008 16:24:03 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Tomas Winkler CC: Johannes Berg , linville@tuxdriver.com, linux-wireless@vger.kernel.org Subject: Re: [RFC] mac80211: add rate to ieee80211_tx_status References: <12020697053277-git-send-email-tomas.winkler@intel.com> <-2417195033053015320@unknownmsgid> <1ba2fa240802040326v425fe147y52f2d8731e3012cb@mail.gmail.com> <1ba2fa240802040330o5b9ffb2dk32b28f7f959e49f4@mail.gmail.com> <5358276387473684738@unknownmsgid> <1ba2fa240802040357vf517e6as374540e28dd1ab56@mail.gmail.com> <47A718CF.50303@openwrt.org> <-5971017268625562167@unknownmsgid> <1ba2fa240802040621h2c0e9fe6yb5d84d24513aedf4@mail.gmail.com> <-7767648866191425885@unknownmsgid> <1ba2fa240802040713k56fdf22fp8ab15924bbebe88@mail.gmail.com> In-Reply-To: <1ba2fa240802040713k56fdf22fp8ab15924bbebe88@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Tomas Winkler wrote: >> > Maybe we should add blob to tx_status let say of skb->cb[] size and >> > field for rate scale algorithm version/name. Otherwise we will be >> > inventing API for each rate scale algorithm... >> >> I disagree, we should have something generic enough to allow some sort of >> "capability negotiation" between the driver and the rate control >> algorithm, otherwise we could just remove rate control algorithms >> completely and internalize them into drivers (with some "helper" functions >> for those who don't want to write their own)... Which I'm sure you might >> actually like but I don't ;) > > So Felix how many rates do you need for each packet? The algorithm is designed to work with 4 different rates with adjustable retry counts. A good description can be found here: http://madwifi.org/browser/madwifi/trunk/ath_rate/minstrel/minstrel.txt - Felix