Return-path: Received: from nf-out-0910.google.com ([64.233.182.184]:49902 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752532AbYBSJ1D (ORCPT ); Tue, 19 Feb 2008 04:27:03 -0500 Received: by nf-out-0910.google.com with SMTP id g13so626863nfb.21 for ; Tue, 19 Feb 2008 01:27:02 -0800 (PST) To: chris2553@googlemail.com Subject: Re: 2.6.25-rc2 regression in rt61pci wireless driver Date: Tue, 19 Feb 2008 10:26:57 +0100 Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <200802181911.32128.IvDoorn@gmail.com> <200802182251.35630.chris2553@googlemail.com> In-Reply-To: <200802182251.35630.chris2553@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Message-Id: <200802191026.57640.IvDoorn@gmail.com> (sfid-20080219_092712_303886_4DD23E48) From: Ivo van Doorn Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, > > I have a series of tests I would like to request from you, > > you mentioned you already enabled debugfs, and that is just what we need. ;) > > Please use attached script to create dumps of the hardware register contents. > > > > There are specific moments that should be dumped: > > - kernel 2.6.24 (last known working version for you). > > - kernel 2.6.25-rc2 (after ifup, before TX dies) > > - kernel 2.6.25-rc2 (after ifup, after TX dies) > > > > These diagnostics are attached, with obvious filenames. Thanks. I think I found something, please test below patch: --- diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c index 015738a..8df1991 100644 --- a/drivers/net/wireless/rt2x00/rt2x00dev.c +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c @@ -249,10 +249,10 @@ static void rt2x00lib_evaluate_antenna(struct rt2x00_dev *rt2x00dev) rt2x00dev->link.ant.flags &= ~ANTENNA_TX_DIVERSITY; if (rt2x00dev->hw->conf.antenna_sel_rx == 0 && - rt2x00dev->default_ant.rx != ANTENNA_SW_DIVERSITY) + rt2x00dev->default_ant.rx == ANTENNA_SW_DIVERSITY) rt2x00dev->link.ant.flags |= ANTENNA_RX_DIVERSITY; if (rt2x00dev->hw->conf.antenna_sel_tx == 0 && - rt2x00dev->default_ant.tx != ANTENNA_SW_DIVERSITY) + rt2x00dev->default_ant.tx == ANTENNA_SW_DIVERSITY) rt2x00dev->link.ant.flags |= ANTENNA_TX_DIVERSITY; if (!(rt2x00dev->link.ant.flags & ANTENNA_RX_DIVERSITY) &&