Return-path: Received: from mail30f.wh2.ocn.ne.jp ([220.111.41.203]:24678 "HELO mail30f.wh2.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757436AbYBVAvR (ORCPT ); Thu, 21 Feb 2008 19:51:17 -0500 From: bruno randolf To: "John W. Linville" Subject: Re: [PATCH] mac80211: fix IBSS code Date: Fri, 22 Feb 2008 09:51:02 +0900 Cc: Johannes Berg , linux-wireless , Pavel Roskin References: <1203588513.17534.138.camel@johannes.berg> <1203621836.26341.4.camel@johannes.berg> <20080221194307.GL3094@tuxdriver.com> In-Reply-To: <20080221194307.GL3094@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200802220951.02985.bruno@thinktube.com> (sfid-20080222_005121_182402_B433E48A) Sender: linux-wireless-owner@vger.kernel.org List-ID: On Friday 22 February 2008 04:43:07 John W. Linville wrote: > On Thu, Feb 21, 2008 at 08:23:56PM +0100, Johannes Berg wrote: > > On Thu, 2008-02-21 at 12:07 -0500, John W. Linville wrote: > > > On Thu, Feb 21, 2008 at 11:08:33AM +0100, Johannes Berg wrote: > > > > This patch fixes two errors introduced by > > > > > > > > commit 19d35612f3cd7f60dd9174c0100584e21f5a1025 > > > > Author: Bruno Randolf > > > > Date: Mon Feb 18 11:21:36 2008 +0900 > > > > > > > > mac80211: enable IBSS merging > > > > > > > > The first error is an endianness problem that sparse found and > > > > the second is a build failure when CONFIG_MAC80211_IBSS_DEBUG > > > > is not set. > > > > > > I think I like Pavel's fix for the CONFIG_MAC80211_IBSS_DEBUG build > > > issue better. Do you want to repsin the sparse warning bit? If you > > > like, I can respin it for you -- just let me know. > > > > Eh, where do we stand now? Bruno wanted the message to not be rate > > limited in the DEBUG case, and the endianness fix is definitely > > required. > > I'll rebase your original patch on top of what is there now. I.E. the > result will be as if I had only applied your patch. sorry, i should have tested the patch with IBSS debugging disabled, too :( bruno