Return-path: Received: from embla.aitel.hist.no ([158.38.50.22]:54764 "EHLO embla.aitel.hist.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbYCEN66 (ORCPT ); Wed, 5 Mar 2008 08:58:58 -0500 Message-ID: <47CEA5CB.6040001@aitel.hist.no> (sfid-20080305_135901_259199_4EABA6FE) Date: Wed, 05 Mar 2008 14:53:15 +0100 From: Helge Hafting MIME-Version: 1.0 To: Joonwoo Park CC: linville@tuxdriver.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] mac80211: fix races between siwessid and siwencode References: <1204710009-10040-1-git-send-email-joonwpark81@gmail.com> <20080305094859.GA10077@ehus.geninetworks.com> In-Reply-To: <20080305094859.GA10077@ehus.geninetworks.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Joonwoo Park wrote: > On Wed, Mar 05, 2008 at 06:40:09PM +0900, Joonwoo Park wrote: > >> resolve: http://bughost.org/bugzilla/show_bug.cgi?id=1522 >> >> The function ieee80211_ioctl_siwencode shouldn't be called if >> authentication process is not completed. >> This patch makes the ieee80211_ioctl_siwessid to wait for authentication >> is completed. >> >> Signed-off-by: Joonwoo Park >> > > Helge, > > Can you please try this patch? > I believe this patch helps your problem. > I tried it, and still have problems. The messages may be slightly different: I first bring up the interface with "ifconfig wlan0 up" and then try "iwconfig wlan0 essid my_essid key s:password" over and over till it works. This gave me: Initial auth_alg=0 wlan0: authenticate with AP 00:14:1b:5e:13:40 wlan0: authenticate with AP 00:14:1b:5e:13:40 wlan0: authenticate with AP 00:14:1b:5e:13:40 wlan0: authentication with AP 00:14:1b:5e:13:40 timed out A total of 5 tries went wrong. The sixth time it worked, with different messages and a different access point. (There are several access points at work.) Initial auth_alg=0 wlan0: authenticate with AP 00:12:7f:ce:9c:e0 wlan0: RX authentication from 00:12:7f:ce:9c:e0 (alg=0 transaction=2 status=0) wlan0: authenticated wlan0: associate with AP 00:12:7f:ce:9c:e0 (capab=0x431 status=0 aid=242) wlan0: associated wlan0: CTS protection enabled (BSSID=00:12:7f:ce:9c:e0) wlan0: switched to long barker preamble (BSSID=BSSID=00:12:7f:ce:9c:e0) wlan0: WMM queue=2 aci=0 acm=0 aifs=3 cWmin=15 cWmax=1023 burst=0 wlan0: WMM queue=3 aci=1 acm=0 aifs=7 cWmin=15 cWmax=1023 burst=0 wlan0: WMM queue=1 aci=2 acm=0 aifs=2 cWmin=7 cWmax=15 burst=30 wlan0: WMM queue=0 aci=3 acm=0 aifs=2 cWmin=3 cWmax=7 burst=15 wlan0: link becomes ready Only 6 attempts is an improvement, if it stays that way. Still, the old ipw3945 succeeded on first try. :-/ I hope the testing can be of help. Helge Hafting