Return-path: Received: from py-out-1112.google.com ([64.233.166.180]:38981 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbYCZW7M (ORCPT ); Wed, 26 Mar 2008 18:59:12 -0400 Received: by py-out-1112.google.com with SMTP id u52so5970913pyb.10 for ; Wed, 26 Mar 2008 15:59:12 -0700 (PDT) Message-ID: <43e72e890803261559keb944a1g48d93645db2f2e73@mail.gmail.com> (sfid-20080326_225917_649952_7195B5D6) Date: Wed, 26 Mar 2008 18:59:11 -0400 From: "Luis R. Rodriguez" To: "Bruno Randolf" Subject: Re: [PATCH] mac80211: use hardware flags for signal/noise units Cc: ath5k-devel@lists.ath5k.org, jirislaby@gmail.com, mickflemm@gmail.com, linux-wireless@vger.kernel.org, linville@tuxdriver.com, johannes@sipsolutions.net, flamingice@sourmilk.net, jbenc@suse.cz, "Ivan Seskar" , "Jean Tourrilhes" , "Haris Kremo" In-Reply-To: <20080326123042.11233.80949.stgit@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <20080326123042.11233.80949.stgit@localhost> Sender: linux-wireless-owner@vger.kernel.org List-ID: SmVhbiBhIHF1ZXN0aW9uIG9yIHR3byBmb3IgeW91IGJlbG93LgoKT0sgSSBrbm93IEkgc2VlbWVk IGhhcHB5IHdpdGggdGhlIG9yaWdpbmFsIHBhdGNoIGJ1dCBhZnRlciBzb21lCnRob3VnaHQgSSBo YXZlIHNvbWUgY29uY2VybnMuIFRoZXkgYXJlIGJlbG93LgoKT24gV2VkLCBNYXIgMjYsIDIwMDgg YXQgODozMCBBTSwgQnJ1bm8gUmFuZG9sZiA8YnJ1bm9AdGhpbmt0dWJlLmNvbT4gd3JvdGU6Cgo+ ICBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9uZXQvbWFjODAyMTEuaCBiL2luY2x1ZGUvbmV0L21hYzgw MjExLmgKCj4gIEBAIC02OTcsNiArNzAxLDI0IEBAIGVudW0gaWVlZTgwMjExX3RraXBfa2V5X3R5 cGUgewo+ICAgKiBASUVFRTgwMjExX0hXXzJHSFpfU0hPUlRfUFJFQU1CTEVfSU5DQVBBQkxFOgo+ ICAgKiAgICAgSGFyZHdhcmUgaXMgbm90IGNhcGFibGUgb2YgcmVjZWl2aW5nIGZyYW1lcyB3aXRo IHNob3J0IHByZWFtYmxlIG9uCj4gICAqICAgICB0aGUgMi40IEdIeiBiYW5kLgo+ICArICoKPiAg KyAqIEBJRUVFODAyMTFfSFdfU0lHTkFMX1VOU1BFQzoKPiAgKyAqICAgICBIYXJkd2FyZSBjYW4g cHJvdmlkZSBzaWduYWwgdmFsdWVzIGJ1dCB3ZSBkb24ndCBrbm93IGl0cyB1bml0cy4gVG8gYmUK PiAgKyAqICAgICBhYmxlIHRvIHN0YW5kYXJkaXplIGJldHdlZW4gZGlmZmVyZW50IGRldmljZXMg d2Ugd291bGQgbGlrZSBsaW5lYXIKPiAgKyAqICAgICB2YWx1ZXMgZnJvbSAwLTEwMC4gSWYgcG9z c2libGUgcGxlYXNlIHByb3ZpZGUgZEIgb3IgZEJtIGluc3RlYWQuCj4gICsgKgo+ICArICogQElF RUU4MDIxMV9IV19TSUdOQUxfREI6Cj4gICsgKiAgICAgSGFyZHdhcmUgZ2l2ZXMgc2lnbmFsIHZh bHVlcyBpbiBkQiwgZGVjaWJlbCBkaWZmZXJlbmNlIGZyb20gYW4KPiAgKyAqICAgICBhcmJpdHJh cnksIGZpeGVkIHJlZmVyZW5jZS4gSWYgcG9zc2libGUgcGxlYXNlIHByb3ZpZGUgZEJtIGluc3Rl YWQuCj4gICsgKgoKU2lnbmFsIHNob3VsZCBnaXZlbiBpbiBlaXRoZXIgYmUgaW4gZEJtIG9yIGFu IHVuc3BlY2lmaWVkIHZhbHVlLiBTaW5jZQp3ZSBoYXZlICJ1bnNwZWNpZmllZCIgbm90IHN1cmUg d2h5IHdlIHdvdWxkIGhhdmUgdGhlICJkYiIgdmFsdWUuIENhbgp5b3UgY2xhcmlmeSB3aGF0IHRo ZSBkaWZmZXJlbmNlIGJldHdlZW4gInVuc3BlY2lmaWVkIiBhbmQgImRiIiB3b3VsZApiZT8gSSBk b24ndCB0aGluayBpdCBtYWtlcyBzZW5zZSB0byByZWZlciB0byBzaWduYWwgd2l0aCBhICJkYiIg dmFsdWUsCnVubGVzcyB3ZSB3YW50ICJzaW5nYWwiIGhlcmUgdG8gYmUgYWJsZSB0byBtZWFuIFNO Ui4KCj4gICsgKiBASUVFRTgwMjExX0hXX1NJR05BTF9EQk06Cj4gICsgKiAgICAgSGFyZHdhcmUg Z2l2ZXMgc2lnbmFsIHZhbHVlcyBpbiBkQm0sIGRlY2liZWwgZGlmZmVyZW5jZSBmcm9tCj4gICsg KiAgICAgb25lIG1pbGxpd2F0dC4gVGhpcyBpcyB0aGUgcHJlZmVycmVkIG1ldGhvZCBzaW5jZSBp dCBpcyBzdGFuZGFyZGl6ZWQKPiAgKyAqICAgICBiZXR3ZWVuIGRpZmZlcmVudCBkZXZpY2VzLgo+ ICArICoKPiAgKyAqIEBJRUVFODAyMTFfSFdfTk9JU0VfREJNOgo+ICArICogICAgIEhhcmR3YXJl IGNhbiBwcm92aWRlIG5vaXNlIGZsb29yIHZhbHVlcyBpbiB1bml0cyBkQm0sIGRlY2liZWwgZGlm ZmVyZW5jZQo+ICArICogICAgIGZyb20gb25lIG1pbGxpd2F0dC4KPiAgICovCj4gICBlbnVtIGll ZWU4MDIxMV9od19mbGFncyB7Cj4gICAgICAgICBJRUVFODAyMTFfSFdfSE9TVF9HRU5fQkVBQ09O X1RFTVBMQVRFICAgICAgICAgICA9IDE8PDAsCj4gIEBAIC03MDQsNiArNzI2LDEwIEBAIGVudW0g aWVlZTgwMjExX2h3X2ZsYWdzIHsKPiAgICAgICAgIElFRUU4MDIxMV9IV19IT1NUX0JST0FEQ0FT VF9QU19CVUZGRVJJTkcgICAgICAgID0gMTw8MiwKPiAgICAgICAgIElFRUU4MDIxMV9IV18yR0ha X1NIT1JUX1NMT1RfSU5DQVBBQkxFICAgICAgICAgID0gMTw8MywKPiAgICAgICAgIElFRUU4MDIx MV9IV18yR0haX1NIT1JUX1BSRUFNQkxFX0lOQ0FQQUJMRSAgICAgID0gMTw8NCwKPiAgKyAgICAg ICBJRUVFODAyMTFfSFdfU0lHTkFMX1VOU1BFQyAgICAgICAgICAgICAgICAgICAgICA9IDE8PDUs Cj4gICsgICAgICAgSUVFRTgwMjExX0hXX1NJR05BTF9EQiAgICAgICAgICAgICAgICAgICAgICAg ICAgPSAxPDw2LAo+ICArICAgICAgIElFRUU4MDIxMV9IV19TSUdOQUxfREJNICAgICAgICAgICAg ICAgICAgICAgICAgID0gMTw8NywKPiAgKyAgICAgICBJRUVFODAyMTFfSFdfTk9JU0VfREJNICAg ICAgICAgICAgICAgICAgICAgICAgICA9IDE8PDgsCj4gICB9Owo+Cj4gICAvKioKCjwtLSBzbmlw IC0tPgoKPiAgZGlmZiAtLWdpdCBhL25ldC9tYWM4MDIxMS9pZWVlODAyMTFfaW9jdGwuYyBiL25l dC9tYWM4MDIxMS9pZWVlODAyMTFfaW9jdGwuYwo+ICBpbmRleCA1YWYyM2QzLi43MzFlY2QyIDEw MDY0NAo+ICAtLS0gYS9uZXQvbWFjODAyMTEvaWVlZTgwMjExX2lvY3RsLmMKPiAgKysrIGIvbmV0 L21hYzgwMjExL2llZWU4MDIxMV9pb2N0bC5jCj4gIEBAIC0xNTgsMTIgKzE1OCwyMCBAQCBzdGF0 aWMgaW50IGllZWU4MDIxMV9pb2N0bF9naXdyYW5nZShzdHJ1Y3QgbmV0X2RldmljZSAqZGV2LAo+ ICAgICAgICAgcmFuZ2UtPm51bV9lbmNvZGluZ19zaXplcyA9IDI7Cj4gICAgICAgICByYW5nZS0+ bWF4X2VuY29kaW5nX3Rva2VucyA9IE5VTV9ERUZBVUxUX0tFWVM7Cj4KPiAgLSAgICAgICByYW5n ZS0+bWF4X3F1YWwucXVhbCA9IGxvY2FsLT5ody5tYXhfc2lnbmFsOwo+ICAtICAgICAgIHJhbmdl LT5tYXhfcXVhbC5sZXZlbCA9IGxvY2FsLT5ody5tYXhfcnNzaTsKPiAgLSAgICAgICByYW5nZS0+ bWF4X3F1YWwubm9pc2UgPSBsb2NhbC0+aHcubWF4X25vaXNlOwo+ICArICAgICAgIHJhbmdlLT5t YXhfcXVhbC5sZXZlbCA9IDA7Cj4gICsgICAgICAgaWYgKGxvY2FsLT5ody5mbGFncyAmIElFRUU4 MDIxMV9IV19TSUdOQUxfVU5TUEVDKQo+ICArICAgICAgICAgICAgICAgcmFuZ2UtPm1heF9xdWFs LmxldmVsID0gMTAwOwo+ICArICAgICAgIGVsc2UgaWYgIChsb2NhbC0+aHcuZmxhZ3MgJiBJRUVF ODAyMTFfSFdfU0lHTkFMX0RCKQo+ICArICAgICAgICAgICAgICAgIC8qIHRoaXMgaXMgcHJldHR5 IGFyYml0cmFyeSBidXQgdGhlIHJhbmdlIG9mIG1vc3QgZHJpdmVycyAqLwo+ICArICAgICAgICAg ICAgICAgIHJhbmdlLT5tYXhfcXVhbC5sZXZlbCA9IDY0Owo+ICArICAgICAgIGVsc2UgaWYgIChs b2NhbC0+aHcuZmxhZ3MgJiBJRUVFODAyMTFfSFdfU0lHTkFMX0RCTSkKPiAgKyAgICAgICAgICAg ICAgIHJhbmdlLT5tYXhfcXVhbC5sZXZlbCA9IC0xMTA7Cj4gICsKPiAgKyAgICAgICByYW5nZS0+ bWF4X3F1YWwubm9pc2UgPSAtMTEwOwo+ICArICAgICAgIHJhbmdlLT5tYXhfcXVhbC5xdWFsID0g MTAwOwo+ICAgICAgICAgcmFuZ2UtPm1heF9xdWFsLnVwZGF0ZWQgPSBsb2NhbC0+d3N0YXRzX2Zs YWdzOwoKSSdtIHByZXR0eSBwZXJwbGV4ZWQgYnkgdGhlIG9yaWdpbmFsIGludGVudGlvbiBvZiBX aXJlbGVzcyBFeHRlbnNpb25zCm1heF9xdWFsLiBUaGUgZG9jdW1lbnRhdGlvbiB3ZSBoYXZlIGZv ciB0aGlzIHN0YXRlczoKCiAgICAgICAgLyogUXVhbGl0eSBvZiBsaW5rICYgU05SIHN0dWZmICov CiAgICAgICAgLyogUXVhbGl0eSByYW5nZSAobGluaywgbGV2ZWwsIG5vaXNlKQogICAgICAgICAq IElmIHRoZSBxdWFsaXR5IGlzIGFic29sdXRlLCBpdCB3aWxsIGJlIGluIHRoZSByYW5nZSBbMCA7 IG1heF9xdWFsXSwKICAgICAgICAgKiBpZiB0aGUgcXVhbGl0eSBpcyBkQm0sIGl0IHdpbGwgYmUg aW4gdGhlIHJhbmdlIFttYXhfcXVhbCA7IDBdLgogICAgICAgICAqIERvbid0IGZvcmdldCB0aGF0 IHdlIHVzZSA4IGJpdCBhcml0aG1ldGljcy4uLiAqLwogICAgICAgIHN0cnVjdCBpd19xdWFsaXR5 ICAgICAgIG1heF9xdWFsOyAgICAgICAvKiBRdWFsaXR5IG9mIHRoZSBsaW5rICovCgptYXhfcXVh bCBpcyBhIHN0cnVjdCB0aG91Z2gsIGl3X3F1YWxpdHkgd2hpY2ggaXM6CgovKgogKiAgICAgIFF1 YWxpdHkgb2YgdGhlIGxpbmsKICovCnN0cnVjdCAgaXdfcXVhbGl0eQp7CiAgICAgICAgX191OCAg ICAgICAgICAgIHF1YWw7ICAgICAgICAgICAvKiBsaW5rIHF1YWxpdHkgKCVyZXRyaWVzLCBTTlIs CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAlbWlzc2VkIGJlYWNv bnMgb3IgYmV0dGVyLi4uKSAqLwogICAgICAgIF9fdTggICAgICAgICAgICBsZXZlbDsgICAgICAg ICAgLyogc2lnbmFsIGxldmVsIChkQm0pICovCiAgICAgICAgX191OCAgICAgICAgICAgIG5vaXNl OyAgICAgICAgICAvKiBub2lzZSBsZXZlbCAoZEJtKSAqLwogICAgICAgIF9fdTggICAgICAgICAg ICB1cGRhdGVkOyAgICAgICAgLyogRmxhZ3MgdG8ga25vdyBpZiB1cGRhdGVkICovCn07CgpKZWFu LCBpZiByYW5nZS0+bWF4X3F1YWwubGV2ZWwgaXMgc2V0IHRvIC0xMTAgZG9lcyB0aGlzIG1lYW4g c2lnbmFsCmxldmVsIGNhbiBiZSBzZXQgb25seSBmcm9tIC0xMTAgdXAgdG8gMCA/IElzIG1heF9x dWFsLmxldmVsIHN1cHBvc2VkCnRvIGJlIHRoZSB3ZWFrZXN0IHNpZ25hbCBwb3NzaWJseSBkZXRl Y3RlZD8KCkFsc28sIHRlY2huaWNhbGx5IHRoZSBub2lzZSBzaG91bGQgY2hhbmdlIGRlcGVuZGlu ZyBvbiB0aGUgY2hhbm5lbCBiYW5kd2lkdGguCgpJRUVFLTgwMi4xMSAgQ2hhbm5lbCBiYW5kd2lk dGgKODAyLjExYSAgICAgICAgMjBNSHoKODAyLjExYiAgICAgICAgMjJNSHoKODAyLjExZyAgICAg ICAgMjBNSHogKGV4Y2VwdCB3aGVuIG9wZXJhdGluZyBpbiA4MDIuMTFiIHJhdGVzKQo4MDIuMTFu ICAgICAgICAyME1IeiwgNDBNSHogKGV4Y2VwdCB3aGVuIG9wZXJhdGluZyBpbiA4MDIuMTFiIHJh dGVzKQoKQXBwbHlpbmcgdGhlIG5vaXNlIHBvd2VyIGZvcm11bGE6CgpQbiA9IGtUQgoKd2hlcmU6 CgprIGlzIEJvbHR6bWFubidzIGNvbnN0YW50LCAxLjM4KjEwXi0yMyBKL0sKVCBpcyB0aGUgdGVt cGVyYXR1cmUgaW4gS2VsdmluIChyb29tIHRlbXBlcmF0dXJlLCAyOTAgSykKQiBpcyB0aGUgc3lz dGVtIGJhbmR3aWR0aCwgaW4gSHoKCk5vdGU6IFdhdHQgPSBKL3MKCkZvciBhIDEgSHogYmFuZHdp ZHRoIGFuZCBhdCAyOTAgSzoKClBuID0gMS4zOCAqIDEwLTIzIEovSyAqIDI5MCBLICogMSBIegpQ biA9IDQuMDAyMDAgKiAxMF4tMjEgSkh6ClBuID0gNC4wMDIwMCAqIDEwXi0yMSBKL3MKUG4gPSA0 LjAwMjAwICogMTBeLTIxIFcKUG4gPSA0LjAwMjAwIMOXIDEwLTE4IG1XCgpUbyBjb252ZXJ0IHRv IEJlbGwsIHdlIGRvIGxvZyAoZm9vKSwgdG8gZGVjaUJlbGwgd2UgZG8gMTAgKiBsb2cgKGZvbykK c286IChkQm0gPT0gZEJtVykKClBuID0gMTAgKiBsb2cgKDQuMDAyMDAgKiAxMF4tMTgpIGRCbQpQ biA9IH4tMTczLjk3NzIyOTE1Njk5ODA3NDAxMjc3IGRCbQpQbiA9IH4tMTc0IGRCbQoKTm93IGFw cGx5aW5nIHRoZSBzYW1lIG5vaXNlIHBvd2VyIGZvcm11bGEsIFBuID0ga1RCLCBhbmQga25vd2lu ZwphbHJlYWR5IC0xNzRkQm0gYXBwbGllcyBmb3IgZWFjaCAxIEh6IHdlIGNhbiBjb21wdXRlIHRo ZSBwb3dlciBub2lzZQpmb3IgZWFjaCBkaWZmZXJpbmcgYmFuZHdpZHRoIGZvciA4MDIuMTE6CgpQ biA9IC0xNzQgZEJtIC8gSHogKyAxMCAqIGxvZyAoQmFuZHdpZHRoKQoKbWNncm9mQG1vbnN0ZXI6 fiQgY2FsYwpDLXN0eWxlIGFyYml0cmFyeSBwcmVjaXNpb24gY2FsY3VsYXRvciAodmVyc2lvbiAy LjEyLjEuMTMpCkNhbGMgaXMgb3BlbiBzb2Z0d2FyZS4gRm9yIGxpY2Vuc2UgZGV0YWlscyB0eXBl OiAgaGVscCBjb3B5cmlnaHQKW1R5cGUgImV4aXQiIHRvIGV4aXQsIG9yICJoZWxwIiBmb3IgaGVs cC5dCgoKOyAtMTc0ICsgKDEwICogbG9nKDIwICogMTBeNikpCiAgICAgICAgfi0xMDAuOTg5NzAw MDQzMzYwMTg4MDQ3OTQKOyAtMTc0ICsgKDEwICogbG9nKDIyICogMTBeNikpCiAgICAgICAgfi0x MDAuNTc1NzczMTkxNzc3OTM3NjQwNDEKOyAtMTc0ICsgKDEwICogbG9nKDQwICogMTBeNikpCiAg ICAgICAgfi05Ny45Nzk0MDAwODY3MjAzNzYwOTU3OQoKU28gSSBkb24ndCBzZWUgd2h5IG5vaXNl IHBvd2VyIHNob3VsZCBiZSAtMTEwLCBpbnN0ZWFkIGhvdyBhYm91dApoYXZpbmcgaXQgc2V0IHRv IC0xMDEgZEJtIGZvciAyMCBNSHogYW5kIDIyIE1IeiBjaGFubmVsIGJhbmR3aWR0aCBhbmQKLTk4 IGRCbSBmb3IgNDAgTUh6IGNoYW5uZWwgYmFuZHdpZHRoIHdoZW4gdXNlZD8gSWYgd2Ugd2FudCB0 byBiZSBldmVuCm1vcmUgZXhhY3Qgd2UgY2FuIHRha2UgaW50byBjb25zaWRlcmF0aW9uIHRoZSBu b2lzZSBmcm9tIHRoZSBhbXBsaWZpZXIKY2hhaW4gZm9yIHRoZSBoYXJkd2FyZSB3aGVuIGtub3du OyBmb3IgZXhhbXBsZSBmb3IgQXRoZXJvcyBpdCBzZWVtcyB0bwpiZSBrbm93biB0byBiZSA1ZEJt IFsxXSBzbyB0aGUgbm9pc2UgZm9yIEF0aGVyb3MgaGFyZHdhcmUgc2hvdWxkCmNoYW5nZSB0byAt OTYgZEJtLgoKWzFdIGh0dHA6Ly9tYWR3aWZpLm9yZy93aWtpL1VzZXJEb2NzL1JTU0kKCiAgTHVp cwo=