Return-path: Received: from rn-out-0910.google.com ([64.233.170.186]:1384 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755459AbYCSTbo (ORCPT ); Wed, 19 Mar 2008 15:31:44 -0400 Received: by rn-out-0910.google.com with SMTP id v46so512161rnb.15 for ; Wed, 19 Mar 2008 12:31:43 -0700 (PDT) Message-ID: <1ba2fa240803181635o6cc264f4s578bbca7e4561c0e@mail.gmail.com> (sfid-20080319_193515_307673_211BFC99) Date: Wed, 19 Mar 2008 01:35:11 +0200 From: "Tomas Winkler" To: drago01 Subject: Re: [ipw3945-devel] iwl3945 rfkill regression Cc: "Chatre, Reinette" , "Dan Williams" , linux-wireless , "Zhu, Yi" , "Cahill, Ben M" , ipw3945-devel In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1ba2fa240801261411x7bb437c9s31aea593537afeba@mail.gmail.com> <47B29F63.6050605@gmail.com> <1ba2fa240803181607n3556955ar39eebdeebacffb7b@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Mar 19, 2008 at 1:10 AM, drago01 wrote: > > On Wed, Mar 19, 2008 at 12:07 AM, Tomas Winkler wrote: > > On Wed, Mar 19, 2008 at 12:06 AM, Chatre, Reinette > > > > wrote: > > > > > > > > > > On Tuesday, March 18, 2008 2:47 PM, drago01 wrote: > > > > > > >> Please note that the driver loads/unloads the firmware during > > > >> interface up/down. That means that the host will not receive rfkill > > > >> events while the interface is down as there is no firmware to deal > > > >> with these events. > > > >> > > > >> Reinette > > > >> > > > > > > > > OK that makes sense. > > > > So a solution would be to not unload the firmware on down when the hw > > > > rfkill is on. Is this a acceptable one or are they other (better > > > > solutions). I can't think of any. And userspace cannot do anything > > > > because bringing the device up and down again to look for the rfkill > > > > status would be racy. > > > > > > Having the firmware unloaded when the interface is down is a requirement > > > for powersaving. We do not want the device to consume power when it is > > > not used. The rfkill status should always be reported accurately when > > > the interface is up. If it is not then it is a bug. > > > > We will catch the HW rfkill event after loading the uCode so there is > > no problem with this. > > Not sure where should be the SW rfkill state stored. > > yeah, but the ucode will be loaded when the device is brought back up, > which does not happen in NM's case. > You mean that NM doesn't have any notification that the radio was enabled again? This one is tricky with 3945...the trivial question is why NM disables the device? In 4965 there is an interrupt announcing rkfil, in 3965 it's event from firmware. There was portably a good reason why the interrupt was added :) Sorry no solution for now. Tomas