Return-path: Received: from einhorn.in-berlin.de ([192.109.42.8]:51752 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbYCUJ3J (ORCPT ); Fri, 21 Mar 2008 05:29:09 -0400 Message-ID: <47E37F86.2080804@s5r6.in-berlin.de> (sfid-20080321_092915_495416_C676DD79) Date: Fri, 21 Mar 2008 10:27:34 +0100 From: Stefan Richter MIME-Version: 1.0 To: Andrew Morton CC: Henrique de Moraes Holschuh , David Brownell , Richard Purdie , linux-kernel@vger.kernel.org, Ingo Molnar , Geert Uytterhoeven , netdev@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, video4linux-list@redhat.com, lm-sensors@lm-sensors.org Subject: Re: use of preempt_count instead of in_atomic() at leds-gpio.c References: <20080316184349.GA28543@khazad-dum.debian.net> <200803161246.23909.david-b@pacbell.net> <20080318001429.896acf51.akpm@linux-foundation.org> <20080320225612.GB20788@khazad-dum.debian.net> <20080320164741.734e838c.akpm@linux-foundation.org> <20080321003604.GC20788@khazad-dum.debian.net> <20080320180802.426ad2d1.akpm@linux-foundation.org> <47E37E04.3080303@s5r6.in-berlin.de> In-Reply-To: <47E37E04.3080303@s5r6.in-berlin.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: I wrote: > Andrew Morton wrote: >> ./drivers/ieee1394/ieee1394_transactions.c >> >> Possibly buggy: deadlockable > > That's in hpsb_get_tlabel(), an exported symbol of the ieee1394 core. > > The in_atomic() there didn't cause problems yet and is unlikely to do so > in the future, because there are no plans for substantial changes to the > whole drivers/ieee1394/ anymore (because of drivers/firewire/). > > Nevertheless I shall look into replacing the in_atomic() by in_softirq() > or something like that. Or extend the API to have separate calls for callers which can sleep and callers which can't. But that may be thwarted by deep call chains. > Touching this legacy code is dangerous though. -- Stefan Richter -=====-==--- --== =-=-= http://arcgraph.de/sr/