Return-path: Received: from gv-out-0910.google.com ([216.239.58.188]:19221 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbYCEHKB (ORCPT ); Wed, 5 Mar 2008 02:10:01 -0500 Received: by gv-out-0910.google.com with SMTP id s4so950983gve.37 for ; Tue, 04 Mar 2008 23:09:59 -0800 (PST) Subject: Re: [PATCH 6/9] drivers/net/wireless/iwlwifi/iwl-4965.c: Correct use of ! and & From: Harvey Harrison To: Ingo Molnar Cc: Christopher Li , Julia Lawall , yi.zhu@intel.com, linux-wireless@vger.kernel.org, ipw3945-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Alexander Viro , linux-sparse@vger.kernel.org, Josh Triplett In-Reply-To: <20080305070201.GA32434@elte.hu> References: <20080305063842.GA24495@elte.hu> <70318cbf0803042249j57d7f3a3j7666961a9132b10b@mail.gmail.com> <20080305070201.GA32434@elte.hu> Content-Type: text/plain Date: Tue, 04 Mar 2008 23:09:55 -0800 Message-Id: <1204700995.17484.7.camel@brick> (sfid-20080305_071010_247975_CBC89FE7) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2008-03-05 at 08:02 +0100, Ingo Molnar wrote: > * Christopher Li wrote: > > > I think Al Viro has sent a patch to linux-sparse with subject "[PATCH > > 3/3] catch !x & y brainos" does exactly that. > > ah - nice :-) > > /me checks the linux-sparse archive > > Al's patch is: > > + if (op == '&' && expr->left->type == EXPR_PREOP && > + expr->left->op == '!') > + warning(expr->pos, "dubious: !x & y"); > > i think there might be similar patterns: "x & !y", "!x | y", "x | !y" ? > Well, (!x & y) and (!x | y) are probably the two that might have been intended otherwise. (x & !y), (x | !y) are probably ok. Harvey