Return-path: Received: from rn-out-0910.google.com ([64.233.170.191]:15538 "EHLO rn-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755438AbYDBUPx (ORCPT ); Wed, 2 Apr 2008 16:15:53 -0400 Received: by rn-out-0910.google.com with SMTP id e24so1807910rng.1 for ; Wed, 02 Apr 2008 13:15:51 -0700 (PDT) Message-ID: <1ba2fa240804021315s399111d3ibbb1044e8964de5@mail.gmail.com> (sfid-20080402_211613_415350_B52B2F6F) Date: Wed, 2 Apr 2008 23:15:50 +0300 From: "Tomas Winkler" To: "John W. Linville" Subject: Re: [PATCH] iwlwifi/Kconfg: make IWLWIFI_LEDS invisible Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Andrew Morton" , "Miles Lane" , reinette.chatre@intel.com In-Reply-To: <1207152604-22973-1-git-send-email-linville@tuxdriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1207152604-22973-1-git-send-email-linville@tuxdriver.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Apr 2, 2008 at 7:10 PM, John W. Linville wrote: > Select IWLWIFI_LEDS automatically when either IWL3945_LEDS or > IWL4965_LEDS is selected. This avoids potential misconfigurations > which lead to build failures for iwl-led.c. > > Cc: Miles Lane > Cc: reinette.chatre@intel.com > Signed-off-by: John w. Linville > --- > drivers/net/wireless/iwlwifi/Kconfig | 11 +++++------ > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig > index 4a5c8c0..8137690 100644 > --- a/drivers/net/wireless/iwlwifi/Kconfig > +++ b/drivers/net/wireless/iwlwifi/Kconfig > @@ -3,11 +3,8 @@ config IWLCORE > depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL > > config IWLWIFI_LEDS > - bool "Enable LEDS features in iwlwifi driver" > - depends on IWLCORE && MAC80211_LEDS && LEDS_CLASS > - ---help--- > - This option enables LEDS for the iwlwifi drivers > - > + bool > + default n > > config IWLCORE_RFKILL > boolean "IWLWIFI RF kill support" > @@ -52,7 +49,8 @@ config IWL4965_HT > > config IWL4965_LEDS > bool "Enable LEDS features in iwl4965 driver" > - depends on IWL4965 && IWLWIFI_LEDS > + depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS > + select IWLWIFI_LEDS > ---help--- > This option enables LEDS for the iwlwifi drivers > > @@ -137,6 +135,7 @@ config IWL3945_SPECTRUM_MEASUREMENT > config IWL3945_LEDS > bool "Enable LEDS features in iwl3945 driver" > depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS > + select IWLWIFI_LEDS 3945 is for now not dependent at all on this flag. Otherwise looks OK