Return-path: Received: from smtp2.dnainternet.fi ([87.94.96.112]:41863 "EHLO smtp2.dnainternet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751277AbYDXJ0a (ORCPT ); Thu, 24 Apr 2008 05:26:30 -0400 Message-ID: <20080424122628.zioaht24o4ko4ww8@naisho.dyndns.info> (sfid-20080424_112704_329416_1E88F65C) Date: Thu, 24 Apr 2008 12:26:28 +0300 From: Jussi Kivilinna To: Johannes Berg Cc: Roel Kluin <12o3l@tiscali.nl>, linux-wireless@vger.kernel.org, lkml Subject: Re: [PATCH] wireless: rndis_wlan: modparam_workaround_interval is never below 0. References: <480F97B5.9030009@tiscali.nl> (sfid-20080423_221109_783456_35B212E0) <1209027451.3357.49.camel@johannes.berg> In-Reply-To: <1209027451.3357.49.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Sender: linux-wireless-owner@vger.kernel.org List-ID: Quoting Johannes Berg : > > Eh, why not make the modparam unsigned and default to 500? > > johannes > Now that I stop and think about it, that would be better option. The modparam already has default value of 500. Reason why workaround modparam is signed, is that value -1 did have some functionality in some early version. That then changed and priv->param_workaround_interval changed to unsigned and forgot about modparam. - Jussi Kivilinna