Return-path: Received: from wf-out-1314.google.com ([209.85.200.173]:33859 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbYELMij (ORCPT ); Mon, 12 May 2008 08:38:39 -0400 Received: by wf-out-1314.google.com with SMTP id 27so2290871wfd.4 for ; Mon, 12 May 2008 05:38:37 -0700 (PDT) Message-ID: (sfid-20080512_143859_356441_D7E7CC6D) Date: Mon, 12 May 2008 14:38:37 +0200 From: drago01 To: "Tomas Winkler" Subject: Re: dynamic wep with mulitple keys Cc: "Emmanuel Grumbach" , "Volker Braun" , "Linux Wireless" , "Johannes Berg" In-Reply-To: <1ba2fa240805120522m26904f72l45941b1beb411e60@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1208969544.3312.5.camel@localhost.localdomain> <8704f27d0805052346u24954211l6f55513c78205586@mail.gmail.com> <8704f27d0805060032g2312e7dcwc19f382c431e6cd3@mail.gmail.com> <8704f27d0805060514i59db36f0t9801fab7543b8655@mail.gmail.com> <1ba2fa240805120507r2914d23dt6826a732730fea49@mail.gmail.com> <1ba2fa240805120522m26904f72l45941b1beb411e60@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, May 12, 2008 at 2:22 PM, Tomas Winkler wrote: > > On Mon, May 12, 2008 at 3:10 PM, drago01 wrote: > > On Mon, May 12, 2008 at 2:07 PM, Tomas Winkler wrote: > >> > >> On Mon, May 12, 2008 at 2:47 PM, drago01 wrote: > >> > On Tue, May 6, 2008 at 2:14 PM, Emmanuel Grumbach > wrote: > >> >> > >> >> On Tue, May 6, 2008 at 3:10 PM, drago01 wrote: > >> >> > > >> >> > On Tue, May 6, 2008 at 9:32 AM, Emmanuel Grumbach > >> wrote: > >> >> > > > >> >> > > On Tue, May 6, 2008 at 10:22 AM, drago01 wrote: > >> >> > > > On Tue, May 6, 2008 at 8:46 AM, Emmanuel Grumbach > >> wrote: > >> >> > > > > > I just tried compat-wireless-2008-05-05, which > does contain > >> >> > > > > > 03dcb07e74a62eec2badb9f6a091790c484f4a6c. No difference: > >> >> > > > > > > >> >> > > > > > >> >> > > > > Thanks for trying this. > >> >> > > > > Can you try to load the module with swcrypto=1 and > try again ? > >> >> > > > > This disables the HW encryption acceleration. Trying > >> this will allow > >> >> > > > > to make 100% sure that the bug is in iwlwifi. The bug > >> is likely to be > >> >> > > > > there, but I think it is worth to make this 100% sure. > >> >> > > > > >> >> > > > Well it happens for me with iwl3945 which uses swcrypto > >> by default see: > >> >> > > > > >> >> > > > http://marc.info/?l=linux-wireless&m=120699235803881&w=2 > >> >> > > > > >> >> > > > >> >> > > Actually, I made quite a lot of changes in security in > iwl4965 that > >> >> > > are not in iwl3945 so I think it is worth trying with > iwl4965 in SW. > >> >> > > The security code is not the same between 3945 and 4965 > >> >> > > >> >> > OK, are you planning to port this changes/fixes to 3945 ? > >> >> > > >> >> > >> >> Well... Low priority... > >> > > >> > This changes fix an important bug that otherwise make the driver > >> > useless in some configurations. > >> > So I think it should be backported to 3945 (even when development is > >> > focused on newer hardware) > >> > >> But 3945 uses SW encryption this fix is for HW crypto. > > > > I was talking about this: > > "Actually, I made quite a lot of changes in security in iwl4965 that > > are not in iwl3945 so I think it is worth trying with iwl4965 in SW. > > The security code is not the same between 3945 and 4965" > > which seemed to work for Volker using swcrypto > > SW crypto is handled by mac80211 so I ponder why it works above 4965 > and not over 3945 but it has nothing to do with this particular change OK, Johannes any idea why this happens?