Subject: Re: [PATCH] net: wireless: airo semaphore to mutex
From: Daniel Walker <dwalker@mvista.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Dan Williams <dcbw@redhat.com>, linville@tuxdriver.com,
	rusty@rustcorp.com.au, mingo@elte.hu, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, arjan@infradead.org
In-Reply-To: <20080527153406.GL30894@parisc-linux.org>
References: <20080522232103.120033152@mvista.com>
	 <20080527131325.GJ30894@parisc-linux.org>
	 <1211896108.1746.3.camel@localhost.localdomain>
	 <1211900915.18130.251.camel@localhost.localdomain>
	 <20080527153406.GL30894@parisc-linux.org>
Content-Type: text/plain
Date: Tue, 27 May 2008 09:01:58 -0700
Message-Id: <1211904118.3319.3.camel@localhost.localdomain> (sfid-20080527_180213_476869_5BD6072F)
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org


On Tue, 2008-05-27 at 09:34 -0600, Matthew Wilcox wrote:
> On Tue, May 27, 2008 at 08:08:35AM -0700, Daniel Walker wrote:
> > 
> > On Tue, 2008-05-27 at 09:48 -0400, Dan Williams wrote:
> > > 
> > > Yeah, that might be the right way to go.  If you want to jump into the
> > > driver, feel quite free, but I don't think you need to go into too much
> > > detail with it.  Your overall behavior analysis is right on the mark
> > > already.
> > 
> > I think we could just remove the trylock from the interrupt case, and
> > always force the wake_up_interruptible(&priv->thr_wait) case. It looks
> > like the trylocking is just an optimization to save a wakeup ..
> 
> 'just'?  I think you'd see severe performance reductions if you had to
> do a wakeup for every interrupt.

I'd think we would have to know more about how it works before we could
say that for certain, but you might be right .. That may be an unlikely
case tho..

Daniel