Return-path: Received: from miranda.se.axis.com ([193.13.178.8]:40267 "EHLO miranda.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbYEZQPn (ORCPT ); Mon, 26 May 2008 12:15:43 -0400 Message-ID: <07f501c8bf4b$985d1a70$6401a8c0@ADOLAP> (sfid-20080526_181547_292795_2756FE85) Reply-To: "Johan Adolfsson" From: "Johan Adolfsson" To: "Holger Schurig" , "Johan Adolfsson" Cc: , "'Dan Williams'" , , "'John W. Linville'" References: <002701c8bce1$04097010$0137550a@se.axis.com> <200805231657.42433.hs4233@mail.mn-solutions.de> Subject: Re: [PATCH] libertas: before sleeping, check for a command result Date: Mon, 26 May 2008 18:14:37 +0200 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Sender: linux-wireless-owner@vger.kernel.org List-ID: ----- Original Message ----- From: "Holger Schurig" To: "Johan Adolfsson" Cc: ; "'Dan Williams'" ; ; "'John W. Linville'" Sent: Friday, May 23, 2008 4:57 PM Subject: Re: [PATCH] libertas: before sleeping, check for a command result >> I have experience a couple of timeout and resends and after >> sending another commands I get the response from the previous >> one, and the patch seems to solve a couple of those for me - >> still se some problem fetching packet from firmware with ret >> = -22 though. And it could be dependant on how much debug I >> have turned on.. > > Keep in mind that maybe the firmware actually really takes ages > to complete a command. David Woodhouse reported this. > > In my case, because I had the proper debugging statements in my > interrupt handler, I knew for sure that I already received the > response. Can you verify that, for the comment timeouts you > noticed, if this did happen or not? While trying to find out what went wrong I believe I stumbled on a cache issue since our sdio driver didn't invalidate the cache and the DMA is not cachecoherent. Possible something for others to check in their SDIO drivers as well. Ran into some weird problems when trying to verify if it solved my problem though, so I will get back with more info when I get it up and running again. Best regards /Johan