Return-path: Received: from xc.sipsolutions.net ([83.246.72.84]:42673 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754230AbYFLSpN (ORCPT ); Thu, 12 Jun 2008 14:45:13 -0400 Subject: Re: [RFC] Do not activate promiscuous mode on wlan interfaces for bridging. From: Johannes Berg To: Luis Carlos Cobo Cc: linux-wireless@vger.kernel.org, shemminger@linux-foundation.org, j@w1.fi, bridge@linux-foundation.org, Linux Netdev List In-Reply-To: <1213295643.6615.20.camel@localhost> (sfid-20080612_203408_119945_EA437275) References: <1213232760.6645.24.camel@localhost> (sfid-20080612_030607_332834_1EFDE126) <1213255570.3871.8.camel@johannes.berg> <1213294793.6615.16.camel@localhost> (sfid-20080612_202000_504292_98E93460) <1213294852.3730.31.camel@johannes.berg> <1213295643.6615.20.camel@localhost> (sfid-20080612_203408_119945_EA437275) Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rKWwzpBvGHd/yxjrX7Cw" Date: Thu, 12 Jun 2008 20:44:10 +0200 Message-Id: <1213296250.3730.33.camel@johannes.berg> (sfid-20080612_204519_909169_7A628A0E) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: --=-rKWwzpBvGHd/yxjrX7Cw Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2008-06-12 at 11:34 -0700, Luis Carlos Cobo wrote: > On Thu, 2008-06-12 at 20:20 +0200, Johannes Berg wrote: > > Is this a mac80211 driver? When are you activating promisc? >=20 > Yes, libertastf (adaptation of the libertas driver to use a thin > firmware and mac80211), you can check it out at=20 >=20 > git://dev.laptop.org/users/javier/libertastf.git >=20 > Still want to polish it a bit before submitting. >=20 > Promiscuous mode is being activated when attaching the interface to a > bridge, in the lines included in the patch on the first mail in the > thread. But in response to what mac80211 command are you sending the promisc mode to the hw? johannes --=-rKWwzpBvGHd/yxjrX7Cw Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Comment: Johannes Berg (powerbook) iQIcBAABAgAGBQJIUW53AAoJEKVg1VMiehFYOPoP/ix6ZwYtBUAnb6gZv1oXoZS+ UuSBhWUjaVWM/1TBt5KOtLcmGdMGFt4RM4kWeZlBKIep9fWFfc6Odw/wipS6v7pU lovcVYkI4sZpc1YHqBFCiPZaSBR5FFrmug1CdNjghopxb3aKZJIbBhRjnZ2om/0C LaqulsRdgkCZ6Rxu5JCfJ3SFhLcNaOsWy8wHLAIgLIKTi6h/xfQsxIoEzJAFT6s4 5n+qPxqDfGj40RIJ7WB13hYAOWKWaSNBsNsd1qMjf6+BnkbJQoB4B8lUgV+X7EAY l+OemYjVjHBtfdp68zMI5KC+k4bIGAqqib/HEdYGdjCjneQTPBwP66JQemBX/Z8o 26kN8gg88rWMagOqPESD13ZtZ9517RGmvx4+w47n6TLHzhHdwj40Ujk+LTVa/v36 5ia6S9qNrHbfyMVxP04y8WzXWcVgnLTvdY2tWAxp8c25soeMNb5/CLAFl3pd1iCH rCEMdY7zch/zfWqfxvZQVKMk+v8DlnwHzbHTbQVYVhOI1YImHj79LdIQogsrgMUB eZi8vYfrwITROizIXFzf/TOBQA4huSQcd0clk938DfjAhhjBt0FmITdo+Q3YCFci xUHdTJuRw0ZSHU2sDMvDG9sIcGN42Vzs864QJ21t4wB6OUyciLmLmfiHSnRL35e0 jZu5N1hwgnw35GuhQcU7 =yMx2 -----END PGP SIGNATURE----- --=-rKWwzpBvGHd/yxjrX7Cw--