Return-path: Received: from ug-out-1314.google.com ([66.249.92.170]:58005 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbYFEPse (ORCPT ); Thu, 5 Jun 2008 11:48:34 -0400 Received: by ug-out-1314.google.com with SMTP id h2so549970ugf.16 for ; Thu, 05 Jun 2008 08:48:32 -0700 (PDT) To: "Luis R. Rodriguez" Subject: Re: [PATCH] rt2x00: Rename tx_info to info to help compat-wireless revert MQ support for older kernels Date: Thu, 5 Jun 2008 17:57:17 +0200 Cc: "Johannes Berg" , linville@tuxdriver.com, "Ron Rindjunsky" , linux-wireless References: <20080605130734.GD17936@ruslug.rutgers.edu> <1212671763.698.11.camel@johannes.berg> <43e72e890806050626o53134669u775d04b554734164@mail.gmail.com> In-Reply-To: <43e72e890806050626o53134669u775d04b554734164@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200806051757.17232.IvDoorn@gmail.com> (sfid-20080605_174851_707551_362C4471) From: Ivo van Doorn Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thursday 05 June 2008, Luis R. Rodriguez wrote: > On Thu, Jun 5, 2008 at 6:16 AM, Johannes Berg wrote: > > On Thu, 2008-06-05 at 09:07 -0400, Luis R. Rodriguez wrote: > >> Rename tx_info to info as used by other drivers. This will help > >> with CONFIG_NETDEVICES_MULTIQUEUE requirement for HT support support > >> in compat-wireless by allowing us to map skb_get_queue_mapping(skb) > >> to the old info->queue. > >> > >> An alternative is to maintain a large compat.diff which replaces all > >> skb_get_queue_mapping(skb) calls back to info->queue but since this > >> is the only driver which requires name change it seems worth it > >> to help with maintenance. > >> > >> Compat-wireless shouldn't be a reason to accept patches in but if > >> the changes are just cosmetic it seems worth the benefit. > >> > >> Signed-off-by: Luis R. Rodriguez > > > > That's just asking for trouble. If you really _must_ do magic in > > skb_get_queue_mapping, do it directly: > > > > int q = IEEE80211_SKB_CB(skb)->queue; > > Works for me, thanks. Please ignore patch, or not if you want drivers > for some strange reason to be consistent. I just don't need it now. Thanks, I'll drop the patch. ;) Ivo