Return-path: Received: from wa-out-1112.google.com ([209.85.146.181]:12346 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758494AbYFOQr1 convert rfc822-to-8bit (ORCPT ); Sun, 15 Jun 2008 12:47:27 -0400 Received: by wa-out-1112.google.com with SMTP id j37so4020559waf.23 for ; Sun, 15 Jun 2008 09:47:27 -0700 (PDT) Message-ID: <1ba2fa240806150947s1ed9391ao4b1d1a91c871ef8f@mail.gmail.com> (sfid-20080615_184729_971204_1F79DC18) Date: Sun, 15 Jun 2008 19:47:26 +0300 From: "Tomas Winkler" To: "Maxim Levitsky" Subject: Re: [ipw3945-devel] [BUG] iwlwifi 3945 works only with disable_hw_scan=1 Cc: "=?ISO-8859-1?Q?Tor_H=E5kon_Haugen?=" , "Zhu Yi" , linux-wireless@vger.kernel.org, ipw3945-devel@lists.sourceforge.net In-Reply-To: <1ba2fa240806150809h13c28937nd064230baca8a15d@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <484FEA26.1040305@gmail.com> <1213342523.7814.865.camel@debian.sh.intel.com> <20080613130310.GA5333@tuxdriver.com> <48528B63.5030403@gmail.com> <48528CF0.8050204@gmail.com> <1ba2fa240806131304n442972eatfd2f35034476c380@mail.gmail.com> <48551C62.80904@gmail.com> <1ba2fa240806150647mdc97d98oad0b1b02de1fcf87@mail.gmail.com> <48552344.5090801@gmail.com> <1ba2fa240806150809h13c28937nd064230baca8a15d@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Jun 15, 2008 at 6:09 PM, Tomas Winkler wrote= : > On Sun, Jun 15, 2008 at 5:12 PM, Maxim Levitsky wrote: >> Tomas Winkler wrote: >>> >>> On Sun, Jun 15, 2008 at 4:42 PM, Maxim Levitsky >>> wrote: >>>> >>>> Tomas Winkler wrote: >>>>> >>>>> On Fri, Jun 13, 2008 at 6:06 PM, Maxim Levitsky >>>>> >>>>> wrote: >>>>>> >>>>>> Tor H=E5kon Haugen wrote: >>>>>>> >>>>>>> John W. Linville wrote: >>>>>>>> >>>>>>>> On Fri, Jun 13, 2008 at 03:35:23PM +0800, Zhu Yi wrote: >>>>>>>>> >>>>>>>>> On Thu, 2008-06-12 at 09:59 -0400, John W. Linville wrote: >>>>>>>>>> >>>>>>>>>> Honestly I'm tempted to change it to "enable_hw_scan" instea= d... >>>>>>>>> >>>>>>>>> Give the advantages, I'd like to use it if we can fix the bug= (I >>>>>>>>> haven't >>>>>>>>> seen what the bug is myself). But you are free to change the = default >>>>>>>>> value until it is fixed. There is no such problem for 4965, r= ight? >>>>>>>> >>>>>>>> AFAICT only the 3945 seems to need it. >>>>>>>> >>>>>>> I can confirm that this also applies to 4965 as a friend of min= e has >>>>>>> this card. According to him the card works a lot better with th= e >>>>>>> parameters "swcrypto=3D1" and "disable_hw_scan=3D1". >>>>>> >>>>>> Just to make it clear, >>>>>> iwl3945 doesn't work at all without disable_hw_scan=3D1 here. >>>>>> The driver just shuts down thee card since it detects microcode = error. >>>>>> >>>>> It looks like this is all caused by the big rate, band patch. Loo= ks >>>>> like A band scan channels are not configured correctly for the >>>>> scanning. This crashes the firmware. >>>>> >>>>> Tomas >>>> >>>> Probably, I see that eeprom according to dmesg contains no info ab= out A >>>> channels, so maybe this crashes the firmware. >>>> >>> >>> Can you please send your dmesg. >> >> I did that >> (You mean dmesg without disable_hw_scan=3D1?) >> >> If not what debug options I should include >> (I tried same firmware debug options, but the log wrapped around.) >> >> dmesg without disable_hw_scan=3D1 attached. >> >> >>> >>>> I have few questions: >>>> >>>> * Is there a software workaround without the need to update the fi= rmware? >>> >>> Yes >>> >>>> * Is the firmware error so harmful, so driver can't continue? >>> >>> This is firmware misconfiguration. Driver should be friendly to >>> firmware and use correctly API. >>> >>>> * Can I expect updated version of the firmware with fix? >>> >>> No need so far. >>> >>>> Sadly this confirms that firmware is worse that I thought, it is c= loser >>>> to >>>> closed drivers. >>> >>> The firmware API is open, it just wasn't used correctly. >> >> I mean if there is a bug in firmware, nobody expect intel can fix it= =2E > > Intel is fixing bugs in the firmware. Still this doesn't look like a > firmware error. > >> BTW you say that firmware api is open, >> is there a programming manual for this wireless chip? > > it's well documented in -commands.h file Please try this one --- a/drivers/net/wireless/iwlwifi/iwl3945-base.c +++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c @@ -3348,7 +3348,10 @@ static void iwl3945_rx_scan_complete_notif(struct iwl3945_priv *priv, /* Remove this scanned band from the list * of pending bands to scan */ - priv->scan_bands--; + if (priv->cfg->sku & IWL_SKU_A) + priv->scan_bands--; + else + priv->scan_bands =3D 0; > -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html