Return-path: Received: from wa-out-1112.google.com ([209.85.146.177]:24528 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753269AbYFFMHb (ORCPT ); Fri, 6 Jun 2008 08:07:31 -0400 Received: by wa-out-1112.google.com with SMTP id j37so736982waf.23 for ; Fri, 06 Jun 2008 05:07:28 -0700 (PDT) Message-ID: <1ba2fa240806060507s54c33009i9fb9136d4461802d@mail.gmail.com> (sfid-20080606_140736_699444_4C038A39) Date: Fri, 6 Jun 2008 15:07:28 +0300 From: "Tomas Winkler" To: "Luis R. Rodriguez" Subject: Re: [PATCH] rt2x00: Rename tx_info to info to help compat-wirelessrevert MQ support for older kernels Cc: "Rindjunsky, Ron" , "Johannes Berg" , linville@tuxdriver.com, "Ivo van Doorn" , linux-wireless In-Reply-To: <43e72e890806060448g57b23392t7bcaab305eadffd@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <20080605130734.GD17936@ruslug.rutgers.edu> <1212671763.698.11.camel@johannes.berg> <1879838866982C46A9CB3D56BA49ADEB04FA9CFD@hasmsx411.ger.corp.intel.com> <43e72e890806060448g57b23392t7bcaab305eadffd@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Jun 6, 2008 at 2:48 PM, Luis R. Rodriguez wrote: > On Fri, Jun 6, 2008 at 3:39 AM, Rindjunsky, Ron > wrote: >>>> Rename tx_info to info as used by other drivers. This will help >>>> with CONFIG_NETDEVICES_MULTIQUEUE requirement for HT support support >>>> in compat-wireless by allowing us to map skb_get_queue_mapping(skb) >>>> to the old info->queue. >>>> >>>> An alternative is to maintain a large compat.diff which replaces all >>>> skb_get_queue_mapping(skb) calls back to info->queue but since this >>>> is the only driver which requires name change it seems worth it >>>> to help with maintenance. >>>> >>>> Compat-wireless shouldn't be a reason to accept patches in but if >>>> the changes are just cosmetic it seems worth the benefit. >>>> >>>> Signed-off-by: Luis R. Rodriguez >> >>> That's just asking for trouble. If you really _must_ do magic in >>> skb_get_queue_mapping, do it directly: >> >>> int q = IEEE80211_SKB_CB(skb)->queue; >> >> Aren't we heading into to troubles here? In kernels < 2.6.23 there is no >> skb->queue_mapping. queue was once passed in the cb, but now that queue >> was removed from info and info takes cb we are going to have a compat >> problem. > > This is only going to be done for <= 2.6.22. > > Luis First we have to find out why this tx_info to cb patch broke iwlwifi Tomas > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >