Return-path: Received: from qw-out-2122.google.com ([74.125.92.27]:47106 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758001AbYGPQMX (ORCPT ); Wed, 16 Jul 2008 12:12:23 -0400 Received: by qw-out-2122.google.com with SMTP id 3so329856qwe.37 for ; Wed, 16 Jul 2008 09:12:22 -0700 (PDT) Message-ID: <40f31dec0807160912t54316c26nedfff2d756f16b5a@mail.gmail.com> (sfid-20080716_181251_515256_ECC16651) Date: Wed, 16 Jul 2008 19:12:21 +0300 From: "Nick Kossifidis" To: "Jiri Slaby" Subject: Re: [PATCH 2/5] Ath5k: kill tasklets on shutdown Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "Luis R. Rodriguez" In-Reply-To: <1216136661-10930-2-git-send-email-jirislaby@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <1216136661-10930-1-git-send-email-jirislaby@gmail.com> <1216136661-10930-2-git-send-email-jirislaby@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: 2008/7/15 Jiri Slaby : > Don't forget to kill tasklets on stop to not panic if they > fire after freeing some structures. > > Signed-off-by: Jiri Slaby > Cc: Nick Kossifidis > Cc: Luis R. Rodriguez > --- > drivers/net/wireless/ath5k/base.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c > index e9ec284..4d9ff97 100644 > --- a/drivers/net/wireless/ath5k/base.c > +++ b/drivers/net/wireless/ath5k/base.c > @@ -2343,6 +2343,9 @@ ath5k_stop_hw(struct ath5k_softc *sc) > mutex_unlock(&sc->lock); > > del_timer_sync(&sc->calib_tim); > + tasklet_kill(&sc->rxtq); > + tasklet_kill(&sc->txtq); > + tasklet_kill(&sc->restq); > > return ret; > } > -- > 1.5.6.2 > > Acked-by: Nick Kossifidis -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick