Return-path: Received: from n11b.bullet.mail.mud.yahoo.com ([209.191.125.178]:35396 "HELO n11b.bullet.mail.mud.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756384AbYGBObQ (ORCPT ); Wed, 2 Jul 2008 10:31:16 -0400 Message-ID: <486B8FCF.8080201@yahoo.it> (sfid-20080702_163120_395468_EB5E0E34) Date: Wed, 02 Jul 2008 16:25:19 +0200 From: Filippo Zangheri MIME-Version: 1.0 To: Darren Jenkins CC: kernel Janitors , LKML , ipw2100-admin@linux.intel.com, yi.zhu@intel.com, reinette.chatre@intel.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH] drivers/net/wireless/iwlwifi/iwl-3945.c References: <1214962647.18261.15.camel@localhost.localdomain> In-Reply-To: <1214962647.18261.15.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: (Cc'ing linux-wireless) On 02/07/2008 03:37, Darren Jenkins\ wrote: > G'day people >=20 > Coverity CID: 2265 NEGATIVE_RETURNS >=20 > "rate" is of an unsigned type, and the code requires a signed type. > The following patch makes it so. >=20 > Only compile tested. >=20 > =EF=BB=BFSigned-off-by: Darren Jenkins >=20 > diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wi= reless/iwlwifi/iwl-3945.c > index 62a3d8f..31d38cd 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-3945.c > +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c > @@ -449,7 +449,7 @@ static void iwl3945_dbg_report_frame(struct iwl39= 45_priv *priv, > =20 > if (print_summary) { > char *title; > - u32 rate; > + int rate; > =20 > if (hundred) > title =3D "100Frames"; --=20 =46ilippo Zangheri GPG key ID: 0x6C1F2F2F -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html