Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:58847 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752595AbYGAReB (ORCPT ); Tue, 1 Jul 2008 13:34:01 -0400 Date: Tue, 1 Jul 2008 14:33:45 -0300 From: Henrique de Moraes Holschuh To: Johannes Berg Cc: Michael Buesch , Adel Gadllah , linux-wireless@vger.kernel.org, stefano.brivio@polimi.it, Larry Finger , "John W. Linville" , Ivo van Doorn Subject: Re: [PATCH/RFC] b43: remove input device usage for rfkill Message-ID: <20080701173345.GA24605@khazad-dum.debian.net> (sfid-20080701_193409_033838_3EBFEBE1) References: <6cf6b73e0807010255x1f2d8a21m8ed3e712012ea757@mail.gmail.com> <200807011227.15805.mb@bu3sch.de> <20080701143439.GA6962@khazad-dum.debian.net> <1214923097.3462.0.camel@johannes.berg> <20080701165036.GB6962@khazad-dum.debian.net> <1214931676.3462.5.camel@johannes.berg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1214931676.3462.5.camel@johannes.berg> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 01 Jul 2008, Johannes Berg wrote: > On Tue, 2008-07-01 at 13:50 -0300, Henrique de Moraes Holschuh wrote: > > On Tue, 01 Jul 2008, Johannes Berg wrote: > > > > 1. It has an input pin that sometimes people connect buttons/switches > > > > to. > > > > > > > > Does that input pin act as an input for a FLIP-FLOP (and that flip-flop > > > > output is the hardware rfkill line), or is it the hardware rfkill line > > > > itself? > > > > > > Neither. It's not hw kill, but it's not just edge detect either, it does > > > have 'kill' and 'not kill' states. > > > > What exactly the input pin does? what exactly the hardware does when > > the input pin state changes? > > The hardware does nothing, it just sets a bit high or low depending on > the input pin. THIS is very interesting alright... and it is *extremely* important, so let's triple verify it, shall we? Please hack the driver to try to transmit data with that bit set to high, and also with that bit set to low. The best way to go about it is probably to disable the rfkill support (so that it doesn't get in the way), hack the check-the-bit function to just printk its state, and see if the radio can effectively transmit and communicate no matter what state the input pin is at. This is very important. It will caracterize that input pin as either an hardware rfkill line, or as an input device (in which case I would be wrong when I asked to remove the input support from b43, but one step at a time). -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh