Return-path: Received: from ik-out-1112.google.com ([66.249.90.182]:52955 "EHLO ik-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbYH1LLk (ORCPT ); Thu, 28 Aug 2008 07:11:40 -0400 Received: by ik-out-1112.google.com with SMTP id c28so161900ika.5 for ; Thu, 28 Aug 2008 04:11:37 -0700 (PDT) Message-ID: <1ba2fa240808280411l4b229cfdnbcb24b3ad5cae1cd@mail.gmail.com> (sfid-20080828_131143_528315_18248E9D) Date: Thu, 28 Aug 2008 14:11:37 +0300 From: "Tomas Winkler" To: "Marcel Holtmann" Subject: Re: [PATCH 09/11] iwlwifi: fix station mimo power save values Cc: "Zhu Yi" , linville@tuxdriver.com, linux-wireless@vger.kernel.org, "Ron Rindjunsky" In-Reply-To: <1219927236.6064.27.camel@californication> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1219915510-3647-1-git-send-email-yi.zhu@intel.com> <1219915510-3647-3-git-send-email-yi.zhu@intel.com> <1219915510-3647-4-git-send-email-yi.zhu@intel.com> <1219915510-3647-5-git-send-email-yi.zhu@intel.com> <1219915510-3647-6-git-send-email-yi.zhu@intel.com> <1219915510-3647-7-git-send-email-yi.zhu@intel.com> <1219915510-3647-8-git-send-email-yi.zhu@intel.com> <1219915510-3647-9-git-send-email-yi.zhu@intel.com> <1219915510-3647-10-git-send-email-yi.zhu@intel.com> <1219927236.6064.27.camel@californication> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Aug 28, 2008 at 3:40 PM, Marcel Holtmann wrote: > Hi Yi, > >> This patch fixes the wrong use of self mimo power save values instead of >> peer's mimo power save values. > > please state the impact of not fixing this. When does this matter. Does > the both sides have to enable this feature and things like this. Okay, we might not be able to do any traffic to the [peer station because by mistake we configured TX to according our RX capability not RX capability of the peer station. Tomas