Return-path: Received: from rv-out-0506.google.com ([209.85.198.232]:26247 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbYHLWEe (ORCPT ); Tue, 12 Aug 2008 18:04:34 -0400 Received: by rv-out-0506.google.com with SMTP id k40so2993532rvb.1 for ; Tue, 12 Aug 2008 15:04:34 -0700 (PDT) Message-ID: <1ba2fa240808121504k34640c45o1fd1e165483f081f@mail.gmail.com> (sfid-20080813_000438_792434_E8D1B2A8) Date: Wed, 13 Aug 2008 01:04:33 +0300 From: "Tomas Winkler" To: "Jiri Slaby" Subject: Re: iwl + iomap + readl/writel Cc: yi.zhu@intel.com, reinette.chatre@intel.com, linux-wireless , "Linux Kernel Mailing List" In-Reply-To: <48A20776.80302@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <48A1F734.7040801@gmail.com> <1ba2fa240808121449j4c04039bu2fc9b58129dc6027@mail.gmail.com> <48A20686.5080402@gmail.com> <1ba2fa240808121457j33a83effo44110a0423d83f@mail.gmail.com> <48A20776.80302@gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Aug 13, 2008 at 12:58 AM, Jiri Slaby wrote: > On 08/12/2008 11:57 PM, Tomas Winkler wrote: >> >> On Wed, Aug 13, 2008 at 12:54 AM, Jiri Slaby wrote: >>> >>> On 08/12/2008 11:49 PM, Tomas Winkler wrote: >>>> >>>> On Tue, Aug 12, 2008 at 11:48 PM, Jiri Slaby >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I spotted that iwl drivers use readl method on an iomap space. IIRC >>>>> some >>>>> archs might return a tag instead of an address expected by >>>>> readl/writel. >>>>> >>>>> I think you should either switch to ioread32/iowrite32 or to ioremap. >>>> >>>> Can you give me reading material on this? >>> >>> No, google will (you can even feel lucky). >> >> I didn't ask for obvious answers :) > > Sorry, I don't remember where/when this was discussed, you have to search > for it. It's okay I'm already digging into it