Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:48835 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624AbYHTB3o (ORCPT ); Tue, 19 Aug 2008 21:29:44 -0400 Date: Tue, 19 Aug 2008 22:29:36 -0300 From: Henrique de Moraes Holschuh To: Philip Langdale Cc: LKML , Matthew Garrett , toshiba_acpi@memebeam.org, Ivo van Doorn , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v5) Message-ID: <20080820012936.GE29336@khazad-dum.debian.net> (sfid-20080820_032950_183622_DB215BD6) References: <48A728B0.8030206@overt.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <48A728B0.8030206@overt.org> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 16 Aug 2008, Philip Langdale wrote: > @@ -607,7 +796,66 @@ static int __init toshiba_acpi_init(void) > } > toshiba_backlight_device->props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1; > > - return (ACPI_SUCCESS(status)) ? 0 : -ENODEV; > + /* Register rfkill switch for Bluetooth */ > + if (hci_get_bt_present(&bt_present) == HCI_SUCCESS && bt_present) { > + toshiba_acpi.rfk_dev = rfkill_allocate(&toshiba_acpi.p_dev->dev, > + RFKILL_TYPE_BLUETOOTH); > + if (!toshiba_acpi.rfk_dev) { > + printk(MY_ERR "unable to allocate rfkill device\n"); > + toshiba_acpi_exit(); > + return -ENOMEM; > + } > + > + toshiba_acpi.rfk_dev->name = toshiba_acpi.bt_name; > + toshiba_acpi.rfk_dev->state = RFKILL_STATE_OFF; Where did that RFKILL_STATE_OFF came from ? :-) Just get rid of it, you override it four statements later anyway... > + toshiba_acpi.rfk_dev->toggle_radio = bt_rfkill_toggle_radio; > + toshiba_acpi.rfk_dev->user_claim_unsupported = 1; > + toshiba_acpi.rfk_dev->data = &toshiba_acpi; > + > + if (hci_get_bt_on(&bt_on) == HCI_SUCCESS && bt_on) { > + toshiba_acpi.rfk_dev->state = RFKILL_STATE_UNBLOCKED; > + } else if (hci_get_radio_state(&radio_on) == HCI_SUCCESS && radio_on) { > + toshiba_acpi.rfk_dev->state = RFKILL_STATE_SOFT_BLOCKED; > + } else { > + toshiba_acpi.rfk_dev->state = RFKILL_STATE_HARD_BLOCKED; > + } i.e. in the code above. Other than that, the rfkill bits look fine to me. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh