Return-path: Received: from wr-out-0506.google.com ([64.233.184.225]:22939 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513AbYIQWpo (ORCPT ); Wed, 17 Sep 2008 18:45:44 -0400 Received: by wr-out-0506.google.com with SMTP id 69so1739865wri.5 for ; Wed, 17 Sep 2008 15:45:41 -0700 (PDT) Message-ID: <43e72e890809171545k5aeaa52dje2223bdbeb97ce7e@mail.gmail.com> (sfid-20080918_004550_730639_DE40F6C5) Date: Wed, 17 Sep 2008 15:45:41 -0700 From: "Luis R. Rodriguez" To: "Tomas Winkler" Subject: Re: [PATCH v2] mac80211: re-enable aggregation Cc: "Johannes Berg" , linville@tuxdriver.com, linux-wireless@vger.kernel.org In-Reply-To: <1ba2fa240809171357p1b190760h19c3e521e100f7e4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 References: <1221535073-6937-1-git-send-email-lrodriguez@atheros.com> <1221547036.8916.1.camel@johannes.berg> <1ba2fa240809171357p1b190760h19c3e521e100f7e4@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Sep 17, 2008 at 1:57 PM, Tomas Winkler wrote: > On Tue, Sep 16, 2008 at 9:37 AM, Johannes Berg > wrote: >> On Mon, 2008-09-15 at 20:17 -0700, Luis R. Rodriguez wrote: >> >>> +/** >>> + * is_part_ampdu - tells us whether this buffer is part of an AMPDU >>> + * >>> + * @skb: the buffer we want to check >>> + * @hw: the &struct ieee80211_hw to check the queue mapping on >>> + */ >>> +static inline bool is_part_ampdu(struct sk_buff *skb, struct ieee80211_hw *hw) >>> +{ >>> + return (skb_get_queue_mapping(skb) >= >>> + ieee80211_num_regular_queues(hw)); >>> +} >>> + >> >> This is making the patch needlessly large and makes it change drivers >> etc, please just keep the flag and set it based on this in master xmit >> after we've cleared the info. >> > Yes, please keep the flag. Otherwise our rate scale algorithm won't work OK -- you can ignore this I like the path you took better. Luis