Return-path: Received: from out1.smtp.messagingengine.com ([66.111.4.25]:37874 "EHLO out1.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbYIPWhj (ORCPT ); Tue, 16 Sep 2008 18:37:39 -0400 Date: Tue, 16 Sep 2008 19:37:29 -0300 From: Henrique de Moraes Holschuh To: Michael Buesch Cc: Carlos Corbacho , bcm43xx-dev@lists.berlios.de, Larry Finger , Adel Gadllah , LKML , wireless Subject: Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a3baf035412c95192b54dfc6f Message-ID: <20080916223729.GC26035@khazad-dum.debian.net> (sfid-20080917_003744_241950_14F2D66B) References: <48CFC03A.8020708@lwfinger.net> <48CFE820.7010305@lwfinger.net> <200809162018.28548.carlos@strangeworlds.co.uk> <200809162125.18978.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <200809162125.18978.mb@bu3sch.de> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 16 Sep 2008, Michael Buesch wrote: > But I don't know how to tell the rfkill subsystem about the states and rfkill_force_state(). Must NOT be called from within atomic contextes, something I haven't got around to find a proper way of fixing, and nobody else seems to be on a rfkill coding frenzy right now. > I'm still waiting for the sane rfkill API where we have three functions > rfkill-allocate > rfkill-hw-state-changed > rfkill-free I won't go on the rfkill-allocate/-free stuff, messing with that API means you need to fix a lot of other people's drivers. But you have the rfkill-hw-state-changed now, it is called rfkill_force_state(). The only crap is that it cannot be called from atomic contexts. > months ago, but is now deprecated it seems (but I don't know what it it > replaced by) is just so really confusing. Read Documentation/rfkill.txt. And the kernel-doc comments on rfkill.c. The rfkill documentation was updated. If you still have doubts after reading the stuff above, ask on linux-wireless and CC me. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh