Return-path: Received: from ug-out-1314.google.com ([66.249.92.173]:32080 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752533AbYIVPLg (ORCPT ); Mon, 22 Sep 2008 11:11:36 -0400 Received: by ug-out-1314.google.com with SMTP id k3so1394247ugf.37 for ; Mon, 22 Sep 2008 08:11:30 -0700 (PDT) Message-ID: (sfid-20080922_171147_488566_09FE728B) Date: Mon, 22 Sep 2008 08:11:30 -0700 From: "Steven Noonan" To: "Luis R. Rodriguez" Subject: Re: [ath9k-devel] ath9k: massive unexplained latency in 2.6.27 (rc5, rc6, probably others) Cc: "Luis Rodriguez" , linux-wireless , LKML , "Senthilkumar Balasubramanian" , "ath9k-devel@lists.ath9k.org" , "Johannes Berg" , "Ingo Molnar" In-Reply-To: <20080922080632.GA20446@tesla> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 References: <1221944338.3023.8.camel@johannes.berg> <43e72e890809201403w2c4511fdv2fe26bbcf49ccdd7@mail.gmail.com> <43e72e890809201426x61c94bfej2dcda1c178be81b@mail.gmail.com> <20080922065453.GD19580@tesla> <20080922080632.GA20446@tesla> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Sep 22, 2008 at 1:06 AM, Luis R. Rodriguez wrote: > Please test the following patch. > > diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c > index c262ef2..9a51739 100644 > --- a/drivers/net/wireless/ath9k/core.c > +++ b/drivers/net/wireless/ath9k/core.c > @@ -681,10 +681,12 @@ int ath_open(struct ath_softc *sc, struct ath9k_channel *initial_chan) > * Enable MIB interrupts when there are hardware phy counters. > * Note we only do this (at the moment) for station mode. > */ > +#if 0 > if (ath9k_hw_phycounters(ah) && > ((sc->sc_ah->ah_opmode == ATH9K_M_STA) || > (sc->sc_ah->ah_opmode == ATH9K_M_IBSS))) > sc->sc_imask |= ATH9K_INT_MIB; > +#endif > /* > * Some hardware processes the TIM IE and fires an > * interrupt when the TIM bit is set. For hardware > It didn't apply to -rc7, but I managed to apply it manually (apparently you made this for wireless-testing?) and added the #if 0. After 7 hours uptime with the driver, no apparent interrupt storm. I'll do more thorough testing later, but I have a 3 hour drive today, and some packing to do, so it'll need to wait a bit. - Steven