Return-path: Received: from out3.smtp.messagingengine.com ([66.111.4.27]:57199 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753547AbYIIQPj (ORCPT ); Tue, 9 Sep 2008 12:15:39 -0400 Date: Tue, 9 Sep 2008 13:15:33 -0300 From: Henrique de Moraes Holschuh To: vasanthakumar thiagarajan Cc: Johannes Berg , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , Jouni Malinen , Luis Rodriguez Subject: Re: [PATCH] ath9k: Add RF kill support Message-ID: <20080909161533.GA31478@khazad-dum.debian.net> (sfid-20080909_181543_358801_8086ADBE) References: <20080909153422.GA7651@vasanth-lnx.users.atheros.com> <1220975170.31304.184.camel@johannes.berg> <48C69E11.5090102@atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <48C69E11.5090102@atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 09 Sep 2008, vasanthakumar thiagarajan wrote: > I just rearranged (purely change in the location of few static functions > in the file) the code to avoid > the prototype declaration of the functions which are called (before > their definition) in case of any > failure during rfkill_register(). That's much better done in two patches. The first patch should just move code around without changing *anything*. You can check the resulting binary to be sure you didn't change any code by mistake. The second patch does the real code changes. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh