Return-path: Received: from mail.atheros.com ([12.36.123.2]:39774 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755420AbYIOXKF (ORCPT ); Mon, 15 Sep 2008 19:10:05 -0400 Date: Mon, 15 Sep 2008 16:09:52 -0700 From: "Luis R. Rodriguez" To: Tomas Winkler CC: Luis Rodriguez , "johannes@sipsolutions.net" , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" Subject: Re: [RFC] mac80211: re-enable aggregation on 2.6.27 Message-ID: <20080915230952.GG22572@tesla> (sfid-20080916_011008_453704_2EBA9080) References: <1221503192-28502-1-git-send-email-lrodriguez@atheros.com> <1ba2fa240809151606l31fe9d8jbdc34e179910ec8f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <1ba2fa240809151606l31fe9d8jbdc34e179910ec8f@mail.gmail.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Sep 15, 2008 at 04:06:18PM -0700, Tomas Winkler wrote: > On Mon, Sep 15, 2008 at 9:26 PM, Luis R. Rodriguez > wrote: > > Re-enable aggregation by addressing skb->cb overwrites > > after insertion into the qdisc. Aggregation was disabled > > after the new TX multiqueue changes were introduced. Instead > > of relying on the skb->cb we use two flags on the skb. > > > > Signed-off-by: Luis R. Rodriguez > > --- > > > > Users have been reporting low rates on 2.6.27 with 11n drivers, the > > problem isbeen 11n aggregation was disabled due to the new TX multique > > changes. We should have addressed this sooner but we just got to it now. > > > > Without addressing this we won't get 11n aggregation on 2.6.27. I tried > > to minimize the changes required. I'm about to test this, it compiles. > > > > If this doesn't get upstream for 27 perhaps distributions are willing to > > carry it around then and if so oh well (grr...). > > > I'm cleaning this up. Great. > I will probably drop skb->is_part_ampdu so no > changes in the drivers will be required. How so? I mean, if the flag is modified it'll need modification. Luis