Date: Thu, 18 Sep 2008 10:18:24 -0300
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Michael Buesch <mb@bu3sch.de>,
	Ivo van Doorn <IvDoorn@gmail.com>
Subject: Re: [PATCH] rfkill: update LEDs for all state changes
Message-ID: <20080918131824.GD1583@khazad-dum.debian.net> (sfid-20080918_151834_029631_0D12FE7F)
References: <20080917023334.GA1187@khazad-dum.debian.net> <1221682077-21170-1-git-send-email-hmh@hmh.eng.br> <48D16EDB.8090700@lwfinger.net> <20080918124318.GB1583@khazad-dum.debian.net> <48D25311.1010805@lwfinger.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <48D25311.1010805@lwfinger.net>
Sender: linux-wireless-owner@vger.kernel.org

On Thu, 18 Sep 2008, Larry Finger wrote:
> Henrique de Moraes Holschuh wrote:
> > Curious.  My patch to rfkill WAS tested, and it DOES fix the same issue you
> > reported (hardware state changes to HARD_BLOCKED do not update the LEDs) in
> > thinkpad-acpi.  It is also an "obviously correct" patch.
> > 
> > What this probably means is that b43 would need a little more rfkill surgery
> > than what Matthew's patch already did.  I will look over Matthew's patch,
> > but my guess is that Michael's comments about the need to add some extra
> > code to b43 to actually synthesize the rfkill state from the separate HW and
> > SW rfkill input lines are a strong hint of where the problem might be.
> 
> You must have missed my mail that shows the corrected patch for b43.
> See http://marc.info/?l=linux-wireless&m=122171448920267&w=2.

Indeed I have.  I will read it now and comment on it.

Thanks for the heads' up :-)

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh